Skip to content

Fix cycle dependency in Ortac/Dune-rules for wrapper plugin #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Lucccyo
Copy link
Contributor

@Lucccyo Lucccyo commented Jul 21, 2025

During the library declaration in the Ortac/dune-rules, the libraries stanza should include ortac-runtime and the original library (e.g., my_lib) instead of the wrapped one.

  (library
   (name named_wrapper)
   (modules named_wrapper)
-   (libraries ortac-runtime named_wrapper)
+   (libraries ortac-runtime my_lib)
   (package my_package))

@Lucccyo
Copy link
Contributor Author

Lucccyo commented Jul 22, 2025

The CI error appears to be not related to the work.

Copy link
Contributor

@art-w art-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for strengthening the cram test by calling dune to check that ortac generates valid rules :)

@n-osborne
Copy link
Collaborator

Nice, thanks!
Two minor remarks:

  • bumping the version number in *monolith.opam files should be done in a separated PR
  • commits should be reordered (fix->test->changelog, or test->fix-> changelog)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants