Implement IEquatable for StringEnum
#739
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
- case insensitivity - `ToString()` implementation - override `==` and `!=` operators
JamieMagee
force-pushed
the
stringenum-iequatable
branch
from
8a4964e to
593146a
Compare
| } | ||
|
|
||
| public override string ToString() => this.StringValue; | ||
|
|
||
| private static ArgumentException GetArgumentException(string? value) => new(string.Format( |
There was a problem hiding this comment.
This could be turned into a throw helper with a DoesNotReturn attribute
There was a problem hiding this comment.
Sorry, I'm not quite sure what you mean here.
|
Looking at if (!Enum.IsDefined(typeof(TEnum), parsedValue))
{
ThrowArgumentException(parsedValue.ToString());
}
this.StringValue = ToEnumString(parsedValue);which already covers the enum ranges possible, and if the
Sorry these are only superficial reviews and the sort of come in piece by piece because I have limited time available. |
Resolves #738
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!