Fix Dockerfile casing warnings and add automated validation #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed chmod command to use absolute path /notify-pr.sh instead of relative path - Added comprehensive GitHub Action workflow to validate Dockerfile builds - Includes Dockerfile linting with hadolint - Tests image build and basic functionality
- Added validate-dockerfile.sh script for local testing - Updated README with development section explaining validation process - Provides both automated CI validation and local testing capabilities
- Added .hadolint.yaml configuration for Dockerfile linting - Fixed trailing whitespace in ENTRYPOINT instruction - Configured trusted registries and rule overrides for better linting
- Added WORKDIR /app before COPY commands to fix DL3045 warnings - Pinned gem versions (octokit:9.2.0, faraday-retry:2.2.1) to fix DL3028 warning - Updated hadolint configuration to remove fixed warnings
- Updated octokit to v10.0.0 - Updated faraday-retry to v2.3.2
ifbyol
approved these changes
Jun 20, 2025
jLopezbarb
approved these changes
Jun 20, 2025
Co-authored-by: Ignacio Fuertes <nacho@okteto.com>
ifbyol
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes casing warnings in the Dockerfile and adds comprehensive automated validation to ensure the Dockerfile always builds successfully.
Changes Made
🐛 Bug Fixes
chmod +x notify-pr.shtochmod +x /notify-pr.shto use the correct absolute path where the file was copied✨ New Features
.github/workflows/dockerfile-validation.ymlthat runs on every push/PR affecting the Dockerfilevalidate-dockerfile.shfor testing the Dockerfile locally before pushing📚 Documentation
.hadolint.yamlwith appropriate rules for this projectTesting
The GitHub Action will automatically validate:
Local Testing
Developers can now run
./validate-dockerfile.shto test changes locally before pushing.This PR was co-created with Okteto AI Agent Fleets 🤖