Fix nested lists and allow list style attribute #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix nested ordered lists which change type not restarting (e.g. nesting a lower-alpha list in a decimal list would not restart the numbering). Added support for parsing the <ol type="1|a|A|i|I"> attribute.
|
|
Just reviewed and did some quick tests. Looks good to me, thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes here:
The first is that nested ordered lists which changed to a different style would not reset numbering. eg:
a. a
b. b
a. a
b. b
Would be put in the openxml as:
a. a
b. b
c. a
d. b
Note how the nested alpha list does not reset numbering. The fix was just to reorder the if/else statements to give priority to restarting nested lists.
The second fix was support of the "type" attribute for the
<ol type="1|a|A|i|I">tag (https://www.w3schools.com/tags/att_ol_type.asp).I had some html which uses the type attribute rather than set the
style="list-style-type"attribute.