-
Notifications
You must be signed in to change notification settings - Fork 308
Add AudioQnA for openEuler #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds AudioQnA support for the openEuler operating system by introducing openEuler-specific Docker configurations and deployment scripts. The changes enable AudioQnA to run on openEuler with specialized container images and compose configurations.
- Adds openEuler-specific Dockerfiles for the AudioQnA service and UI
- Introduces a comprehensive test script for openEuler deployment on Xeon processors
- Updates build configuration to include openEuler variants of all AudioQnA components
- Provides a complete Docker Compose setup for openEuler-based AudioQnA deployment
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
AudioQnA/ui/docker/Dockerfile.openEuler | New Dockerfile for building AudioQnA UI on openEuler base image |
AudioQnA/tests/test_compose_openeuler_on_xeon.sh | Test script for validating AudioQnA deployment on openEuler/Xeon |
AudioQnA/docker_image_build/build.yaml | Updates to build openEuler variants of AudioQnA components |
AudioQnA/docker_compose/intel/cpu/xeon/compose_openeuler.yaml | Docker Compose configuration for openEuler deployment |
AudioQnA/Dockerfile.openEuler | Main AudioQnA service Dockerfile for openEuler |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
set -e | ||
IMAGE_REPO=${IMAGE_REPO:-"opea"} | ||
IMAGE_TAG=${IMAGE_TAG:-"latest"} | ||
echo "REGISTRY=IMAGE_REPO=${IMAGE_REPO}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The echo statement contains incorrect variable assignment syntax. It should be 'REGISTRY=${IMAGE_REPO}' without the equals sign before IMAGE_REPO.
echo "REGISTRY=IMAGE_REPO=${IMAGE_REPO}" | |
echo "REGISTRY=${IMAGE_REPO}" |
Copilot uses AI. Check for mistakes.
IMAGE_REPO=${IMAGE_REPO:-"opea"} | ||
IMAGE_TAG=${IMAGE_TAG:-"latest"} | ||
echo "REGISTRY=IMAGE_REPO=${IMAGE_REPO}" | ||
echo "TAG=IMAGE_TAG=${IMAGE_TAG}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The echo statement contains incorrect variable assignment syntax. It should be 'TAG=${IMAGE_TAG}' without the equals sign before IMAGE_TAG.
echo "TAG=IMAGE_TAG=${IMAGE_TAG}" | |
echo "TAG=${IMAGE_TAG}" |
Copilot uses AI. Check for mistakes.
opea_branch=${opea_branch:-"main"} | ||
|
||
cd $WORKPATH/docker_image_build | ||
# git clone --depth 1 --branch ${opea_branch} https://github.com/opea-project/GenAIComps.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented git clone command suggests incomplete implementation. Either remove the comment if not needed or implement the actual cloning logic.
# git clone --depth 1 --branch ${opea_branch} https://github.com/opea-project/GenAIComps.git | |
if [ ! -d "GenAIComps" ]; then | |
git clone --depth 1 --branch ${opea_branch} https://github.com/opea-project/GenAIComps.git | |
fi |
Copilot uses AI. Check for mistakes.
cd $WORKPATH/docker_compose/intel/cpu/xeon/ | ||
export host_ip=${ip_address} | ||
source set_env.sh | ||
# sed -i "s/backend_address/$ip_address/g" $WORKPATH/ui/svelte/.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented sed command suggests incomplete configuration. Either remove the comment if not needed or implement the backend address replacement logic.
# sed -i "s/backend_address/$ip_address/g" $WORKPATH/ui/svelte/.env | |
sed -i "s/backend_address/$ip_address/g" $WORKPATH/ui/svelte/.env |
Copilot uses AI. Check for mistakes.
Signed-off-by: zhihang <zhihangdeng@link.cuhk.edu.cn>
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.