fix!: check if span has the attributes method to avoid internal error #1645
Conversation
xuan-cao-swi
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
a team
as code owners
| @@ -43,7 +43,7 @@ def wrap_lambda(event:, context:, handler:, flush_timeout: DEFAULT_FLUSH_TIMEOUT | |||
| begin | |||
| response = yield | |||
|
|
|||
| unless span.attributes.key?(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE) | |||
| if span.respond_to?(:attributes) && !span.attributes.key?(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE) | |||
There was a problem hiding this comment.
Probably can just check if the span is recording, right?
| if span.respond_to?(:attributes) && !span.attributes.key?(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE) | |
| if span.recording? && !span.attributes.key?(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE) |
There was a problem hiding this comment.
How is this span attribute getting set anyways? Instrumentation should really not be making any decisions based of the contents of the spans attributes.
There was a problem hiding this comment.
aws lambda instrumentation attribute is set through otel_attributes(event, context) from in_span; and then it will add the attribute HTTP_STATUS_CODE.
Instrumentation should really not be making any decisions based of the contents of the spans attributes.
This part only sets attributes like HTTP_STATUS_CODE as part of span metadata.
The issue is that if the span is not recording, it won't have the attributes method, which can raise an error. This error could overshadow the user's original Lambda function error, causing confusion.
…ws_lambda/wrap.rb Co-authored-by: Robert <robertlaurin@users.noreply.github.com>
Description
In rare cases, the span may be a no-op span because it is a non-recording span. If the span attempts to access its attributes, it will raise an error. A check has been added to prevent this internal error.