WEB-259 replace custom api of loans.service.ts

[gkbishnoi07]

Description

Replaced custom methods in *.ts files that were previously using loansService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.

Updated both:

• Imports to reference the correct generated service classes.
• Method calls to use the OpenAPI-generated implementations.

This helps improve maintainability and aligns with the OpenAPI specification.

Related issues and discussion

WEB-259

[steinwinde]

As pointed out in DM, editing an existing loan of a group or client doesn't work with this code. Diverse Javascript errors are reported in the Chrome console.

[gkbishnoi07]

working on it!

[steinwinde]

Doesn't work for me, see below. Or have I overlooked anything?!

--- snip ---
PS C:\Users\felix\vsc\mifos-pr-2572-3> ng serve
Component HMR has been enabled, see https://angular.dev/hmr for more info.
Application bundle generation failed. [49.119 seconds]

✘ [ERROR] Could not resolve "../loans.service"

src/app/loans/common-resolvers/loan-deferred-income-data.resolver.ts:4:29:
  4 │ import { LoansService } from '../loans.service';
    ╵                              ~~~~~~~~~~~~~~~~~~

✘ [ERROR] TS2307: Cannot find module '../loans.service' or its corresponding type declarations. [plugin angular-compiler]

src/app/loans/common-resolvers/loan-deferred-income-data.resolver.ts:9:29:
  9 │ import { LoansService } from '../loans.service';
    ╵                              ~~~~~~~~~~~~~~~~~~

✘ [ERROR] TS2339: Property 'loanService' does not exist on type 'MakeRepaymentComponent'. [plugin angular-compiler]

src/app/loans/loans-view/loan-account-actions/make-repayment/make-repayment.component.ts:185:9:
  185 │     this.loanService.submitLoanActionButton(this.loanId, data, th...
      ╵          ~~~~~~~~~~~

✘ [ERROR] TS2339: Property 'getLoanTransactionActionTemplate' does not exist on type 'LoansService'. [plugin angular-compiler]

src/app/loans/loans-view/transactions-tab/transactions-tab.component.ts:463:7:
  463 │       .getLoanTransactionActionTemplate(String(loanId), 'interest...
      ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] TS2339: Property 'executeLoansAccountTransactionsCommand' does not exist on type 'LoansService'. [plugin angular-compiler]

src/app/loans/loans-view/transactions-tab/transactions-tab.component.ts:523:15:
  523 │               .executeLoansAccountTransactionsCommand(
      ╵                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

--- snip ---

[gkbishnoi07]

@steinwinde updated! Please check

[steinwinde]

I think it should be noted that Gopi is working on fixing several issues in this...

Screen.Recording.2025-08-06.142743.mp4

[gkbishnoi07]

I'm working on 2-3 errors most probably I will complete it by tomorrow