blob: use uint64_t for cluster start page index #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating blobstore on devices with more than 16 TiB space, the start page index of clusters can execeed UINT32_MAX and result in overflow in uint32_t representation. Use uint64_t instead of uint32_t to avoid the overflow. Change-Id: I8e2586251b1b31ef7520b870af537c3f5792508e Signed-off-by: Jinlong Chen <chenjinlong.cjl@alibaba-inc.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24619 Reviewed-by: Konrad Sztyber <konrad.sztyber@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Reviewed-by: Jim Harris <jim.harris@samsung.com> Community-CI: Mellanox Build Bot Reviewed-by: Changpeng Liu <changpeliu@tencent.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: GangCao <gang.cao@intel.com>
tiagolobocastro
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating blobstore on devices with more than 16 TiB space, the start page index of clusters can execeed UINT32_MAX and result in overflow in uint32_t representation.
Use uint64_t instead of uint32_t to avoid the overflow.
Change-Id: I8e2586251b1b31ef7520b870af537c3f5792508e
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/24619
Reviewed-by: Konrad Sztyber konrad.sztyber@intel.com
Community-CI: Broadcom CI spdk-ci.pdl@broadcom.com
Reviewed-by: Jim Harris jim.harris@samsung.com
Community-CI: Mellanox Build Bot
Reviewed-by: Changpeng Liu changpeliu@tencent.com
Tested-by: SPDK CI Jenkins sys_sgci@intel.com
Reviewed-by: GangCao gang.cao@intel.com