-
Notifications
You must be signed in to change notification settings - Fork 39
fix: remove skipDefaultConversion for lodash transform import #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
What's the easiest way to test this with the Authoring MFE? I always seem to have trouble replacing dependencies with versions that come from a PR. |
OK, that seems to resolve the problem. I managed to test this but it's a messy process - still looking for advice on an easier testing method. |
yes, what I usually do is replace frontend-build inside the node_modules of the MFE to test it. I hope that helps. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
=============================
=============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎉 This PR is included in version 14.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I do that, but I also have to edit the |
Just upgraded the Authoring MFE, and this did fix the issue. Thanks @dcoa ! |
This PR aims to fix #645 (comment)
I tested it with frontend-app-authoring still save some kb during the build and make the imports properly (I tested it running the test)