Skip to content

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Jun 13, 2025

This PR aims to fix #645 (comment)

I tested it with frontend-app-authoring still save some kb during the build and make the imports properly (I tested it running the test)

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 13, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend-build.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bradenmacdonald
Copy link
Contributor

What's the easiest way to test this with the Authoring MFE? I always seem to have trouble replacing dependencies with versions that come from a PR.

@bradenmacdonald
Copy link
Contributor

OK, that seems to resolve the problem.

I managed to test this but it's a messy process - still looking for advice on an easier testing method.

@dcoa
Copy link
Contributor Author

dcoa commented Jun 17, 2025

yes, what I usually do is replace frontend-build inside the node_modules of the MFE to test it. I hope that helps.

@dcoa dcoa merged commit 9b2a18f into openedx:master Jun 17, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e3856b0) to head (e0fc967).
Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #654   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openedx-semantic-release-bot

🎉 This PR is included in version 14.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bradenmacdonald
Copy link
Contributor

yes, what I usually do is replace frontend-build inside the node_modules of the MFE to test it. I hope that helps.

I do that, but I also have to edit the package.json and manually add the version number, because our semantic-release thing doesn't include version numbers and npm then thinks it's the wrong version. And it also doesn't work very well if the dependency is used by another dependency, e.g. if I'm working on an MFE that depends on frontend-build that then depends on the thing I want to test.

@bradenmacdonald
Copy link
Contributor

Just upgraded the Authoring MFE, and this did fix the issue. Thanks @dcoa !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants