Skip to content

Conversation

samuelallan72
Copy link
Contributor

@samuelallan72 samuelallan72 commented Aug 19, 2025

Description

The old version of share has intermittent installation issues, see lovell/sharp#3851 .
These issues are fixed in the latest version, so we should update here. Also update image-minimizer-webpack-plugin to avoid incompatibility issues, because that uses sharp, and the latest version appears to be tested with the latest sharp version.

I did a quick pass over the changelogs for image-minimizer-webpack-plugin and sharp, and couldn't see any breaking changes that would affect how they are used here.

Supporting information

Fixes: #664
Private-ref: BB-9953

Testing instructions

  • verify the tests pass here

Deadline

None

@openedx-webhooks
Copy link

Thanks for the pull request, @samuelallan72!

This repository is currently maintained by @openedx/committers-frontend-build.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

@kaustavb12 kaustavb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: Tested this in sandbox builds
  • I read through the code

@samuelallan72
Copy link
Contributor Author

Thanks @kaustavb12 🙂

@openedx/committers-frontend-build this is ready for engineering review.

@sarina sarina changed the title chore: update sharp and image minimizer plugin chore: update sharp and image minimizer plugin (FC-94) Aug 20, 2025
@sarina
Copy link
Contributor

sarina commented Aug 20, 2025

@samuelallan72 👋🏻 for work that's done as part of an Axim funded contribution, please put the FC number in the PR title (I've done so for you). Thank you!

@samuelallan72
Copy link
Contributor Author

@sarina thanks for that, I'll remember in future! 😁

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Aug 27, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Aug 27, 2025
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (0376cc7) to head (79cb2d4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #665   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarina
Copy link
Contributor

sarina commented Aug 27, 2025

@samuelallan72 could you please rebase this PR? The test matrix has changed recently.

The old version of share has intermittent installation issues, see
lovell/sharp#3851 .
These issues are fixed in the latest version, so we should update
here. Also update image-minimizer-webpack-plugin to avoid
incompatibility issues, because that uses sharp, and the latest version
appears to be tested with the latest sharp version.

Fixes: openedx#664
Private-ref: https://tasks.opencraft.com/browse/BB-9953
@samuelallan72
Copy link
Contributor Author

@sarina sure, rebased! :)

@sarina
Copy link
Contributor

sarina commented Aug 28, 2025

@samuelallan72 thanks! I invited you to the Triage team, so you don't have to wait for test approvals: visit https://github.com/openedx to accept the invitation.

@sarina
Copy link
Contributor

sarina commented Aug 28, 2025

@arbrandes or @brian-smith-tcril could we get some quick 👀 here? This is for improvements to the PR sandboxes.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelallan72 you mentioned

I did a quick pass over the changelogs for image-minimizer-webpack-plugin and sharp, and couldn't see any breaking changes that would affect how they are used here.

Assuming image-minimizer-webpack-plugin is properly semantically versioning their package, that means we only need to check the changes in 4.0.0.

Looking at that release https://github.com/webpack-contrib/image-minimizer-webpack-plugin/releases/tag/v4.0.0 I found

⚠ BREAKING CHANGES

  • minimum supported Node.js version is 18.12.0 (d3f2531)

18 is lower than our minimum supported version, so this is safe to land.

@brian-smith-tcril brian-smith-tcril merged commit 69c02eb into openedx:master Aug 28, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Aug 28, 2025
@samuelallan72
Copy link
Contributor Author

Thanks @sarina , much appreciated! :)

Thanks for your review @brian-smith-tcril ! :)

@samuelallan72 samuelallan72 deleted the samuel/update-sharp branch August 28, 2025 22:13
@samuelallan72
Copy link
Contributor Author

samuelallan72 commented Aug 28, 2025

@sarina @brian-smith-tcril it appears releases may be handled automatically for this repo? Would you have an estimate for when this patch will be released? Thanks :)

@brian-smith-tcril
Copy link
Contributor

@samuelallan72 this commit was marked as "chore" which does not trigger a semantic release. For it to trigger a release it would have needed to be fix or feat. It will be in the next triggered release, which will happen when a fix or feat commit lands.

I'll look through some open PRs to see if there's something safe to land that'll trigger a release.

@openedx-semantic-release-bot

🎉 This PR is included in version 14.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U released
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update sharp dependency
7 participants