-
Notifications
You must be signed in to change notification settings - Fork 39
chore: update sharp and image minimizer plugin (FC-94) #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update sharp and image minimizer plugin (FC-94) #665
Conversation
Thanks for the pull request, @samuelallan72! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: Tested this in sandbox builds
- I read through the code
Thanks @kaustavb12 🙂 @openedx/committers-frontend-build this is ready for engineering review. |
@samuelallan72 👋🏻 for work that's done as part of an Axim funded contribution, please put the FC number in the PR title (I've done so for you). Thank you! |
@sarina thanks for that, I'll remember in future! 😁 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
=============================
=============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@samuelallan72 could you please rebase this PR? The test matrix has changed recently. |
The old version of share has intermittent installation issues, see lovell/sharp#3851 . These issues are fixed in the latest version, so we should update here. Also update image-minimizer-webpack-plugin to avoid incompatibility issues, because that uses sharp, and the latest version appears to be tested with the latest sharp version. Fixes: openedx#664 Private-ref: https://tasks.opencraft.com/browse/BB-9953
3d964da
to
79cb2d4
Compare
@sarina sure, rebased! :) |
@samuelallan72 thanks! I invited you to the Triage team, so you don't have to wait for test approvals: visit https://github.com/openedx to accept the invitation. |
@arbrandes or @brian-smith-tcril could we get some quick 👀 here? This is for improvements to the PR sandboxes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelallan72 you mentioned
I did a quick pass over the changelogs for image-minimizer-webpack-plugin and sharp, and couldn't see any breaking changes that would affect how they are used here.
Assuming image-minimizer-webpack-plugin
is properly semantically versioning their package, that means we only need to check the changes in 4.0.0
.
Looking at that release https://github.com/webpack-contrib/image-minimizer-webpack-plugin/releases/tag/v4.0.0 I found
⚠ BREAKING CHANGES
- minimum supported Node.js version is 18.12.0 (d3f2531)
18 is lower than our minimum supported version, so this is safe to land.
Thanks @sarina , much appreciated! :) Thanks for your review @brian-smith-tcril ! :) |
@sarina @brian-smith-tcril it appears releases may be handled automatically for this repo? Would you have an estimate for when this patch will be released? Thanks :) |
@samuelallan72 this commit was marked as "chore" which does not trigger a semantic release. For it to trigger a release it would have needed to be I'll look through some open PRs to see if there's something safe to land that'll trigger a release. |
🎉 This PR is included in version 14.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
The old version of share has intermittent installation issues, see lovell/sharp#3851 .
These issues are fixed in the latest version, so we should update here. Also update image-minimizer-webpack-plugin to avoid incompatibility issues, because that uses sharp, and the latest version appears to be tested with the latest sharp version.
I did a quick pass over the changelogs for image-minimizer-webpack-plugin and sharp, and couldn't see any breaking changes that would affect how they are used here.
Supporting information
Fixes: #664
Private-ref: BB-9953
Testing instructions
Deadline
None