Skip to content

Conversation

Yo3-Y
Copy link

@Yo3-Y Yo3-Y commented Sep 23, 2024

  • Make the SDK package easier to navigate
Screenshot 2024-09-23 at 11 28 49

…o a dependency for a better folder structure and editing
@teolemon teolemon requested a review from a team September 26, 2024 10:47
@teolemon teolemon requested a review from Copilot August 26, 2025 16:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the SDK package integration by making it part of the Xcode project structure instead of using Swift Package Manager's local package reference. This change improves SDK navigation and organization within the development environment.

  • Replaced local Swift package reference with direct project inclusion
  • Updated package resolution configuration to version 3
  • Changed example configuration from Dutch to French language

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
Example/Sources/AppDelegate.swift Updated language configuration from Dutch to French
Example/Example.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved Updated package resolution format to version 3 with origin hash
Example/Example.xcodeproj/project.pbxproj Removed local Swift package reference and added direct project file reference
Files not reviewed (1)
  • Example/Example.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -15,7 +15,7 @@ class AppDelegate: NSObject, UIApplicationDelegate {

OFFConfig.shared.apiEnv = .production
OFFConfig.shared.country = OpenFoodFactsCountry.POLAND
OFFConfig.shared.productsLanguage = OpenFoodFactsLanguage.DUTCH
OFFConfig.shared.productsLanguage = .FRENCH
Copy link
Preview

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The language change from Dutch to French appears unrelated to the main refactoring purpose. Consider separating this configuration change into a separate commit or PR to maintain clear change history.

Suggested change
OFFConfig.shared.productsLanguage = .FRENCH
OFFConfig.shared.productsLanguage = .DUTCH

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants