-
Notifications
You must be signed in to change notification settings - Fork 823
Add ALU to ALU bypass in superscalar mode #2951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ failed run, report available here. |
e68fb8d
to
e6f7735
Compare
❌ failed run, report available here. |
3 similar comments
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
|
❌ failed run, report available here. |
core/issue_read_operands.sv
Outdated
@@ -813,6 +851,14 @@ module issue_read_operands | |||
if (issue_instr_valid_i[i] && !fu_busy[i]) begin | |||
if (!stall_raw[i]) begin | |||
issue_ack[i] = 1'b1; | |||
// For now keep this as is, we cannot do inter dual-issue forwarding | |||
if (i > 0) begin | |||
if ((issue_instr_i[i].rd[4:0] == issue_instr_i[i-1].rd[4:0]) && (issue_instr_i[i].rd[4:0] != '0)) begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these [4:0]
slicing needed?
Shouldn’t this block of conditions be already managed inside stall_raw[1]
instead of here?
❌ failed run, report available here. |
1 similar comment
❌ failed run, report available here. |
❌ failed run, report available here. |
1 similar comment
❌ failed run, report available here. |
❌ failed run, report available here. |
1 similar comment
❌ failed run, report available here. |
@JeanRochCoulon would it be possible to understand what is failing in the FPGA flow in the CI? I tried to run an FPGA synth locally and it arrives at the end, but I cannot reproduce the CI setup one-to-one. |
❌ failed run, report available here. |
5 similar comments
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
❌ failed run, report available here. |
1 similar comment
❌ failed run, report available here. |
d32cbe1
to
5b0e804
Compare
❌ failed run, report available here. |
❌ failed run, report available here. |
1 similar comment
❌ failed run, report available here. |
❌ failed run, report available here. |
Co-authored-by: Gianmarco Ottavi <ottavig91@gmail.com>
285baf8
to
7b571a7
Compare
775b8f5
to
8e4befc
Compare
❌ failed run, report available here. |
This PR introduce ALU to ALU bypass to allow dual issue of consecutive ALU instructions with a RAW dependency.
The ALUs are now instantiated inside a wrapper module, which provides either a single ALU for the scalar configuration or two ALUs with bypass logic in the superscalar scenario.
When two ALUs are instantiated, CPOP is carried out separately to avoid timing degradation.
At the moment the bypass is activated whenver
SuperscalarEn=1
. If a dedicated parameter is preferred to decouple the two features I can add it.