Skip to content

Bjdooks/update mimpid post fs fix2 #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bjdooks/update mimpid post fs fix2 #3013

wants to merge 3 commits into from

Conversation

bjdooks-ct
Copy link
Contributor

Using the MMMPID to show version of the core code is useful

@bjdooks-ct
Add CSR MIMPID value configuration
34393ce 
Add a config for the MIMPID CSR value so that it can be changed
to denote fixes or architecture to allow software to auto-detect
the core version.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
@bjdooks-ct
Set MMIMPID to '1' to denote fp-dirty fix
975305b 
MIMPID CSR set to 1 to show that the issue of fp-dirty has been
fixed and software no-longer needs to always save the fp state
on a thread/task switch.

See commit 2700d14 for the fix
for the FS status.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

@bjdooks-ct
Copy link
Contributor Author

Is there anything I need to do here, don't understand the failures in the pipeline ?

@github-actions GitHub Actions
Copy link
Contributor

❌ failed run, report available here.

@Gchauvon
Copy link
Contributor

Failure of the pipeline are not related to this PR.

@Gchauvon
Copy link
Contributor

I'm not sure how we should define MIMPID csr. Setting it to 1 after a fix of the FPU seems rushed to me.

@bjdooks-ct
Copy link
Contributor Author

I'm not sure how we should define MIMPID csr. Setting it to 1 after a fix of the FPU seems rushed to me.

I was thinking this is a good idea to increment this each time any serious bug is sorted out. It gives you an idea of the version of the core was used, so this could also increment with new releases, etc.

@JeanRochCoulon
Copy link
Contributor

Hello @bjdooks-ct
Thanks again for contributing.
Your PR raised a discussion topic in OpenHW Mattermost channel (are you in?).
We need definitely to improve the MIMPID strategy, but setting it at 1 is not the wanted strategy. I let you know.

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi there!

This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊

@github-actions github-actions bot added the Status:Stale Issue or PR is stale and hasn't received any updates. label Jul 19, 2025
@bjdooks-ct
Copy link
Contributor Author

Since the MMPID changes for bugfixes seems to be still debatable, should we just merged the configuration update to allow this to be changed from the config or drop the whole lot?

@github-actions github-actions bot removed the Status:Stale Issue or PR is stale and hasn't received any updates. label Jul 22, 2025
@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Jul 22, 2025 •
edited
Loading

A trade-off to prepare the future is to merge your PR, but setting MIMPID to 0.
For information, the MIMPID value will be discussed by end of August
Does it make sense for you doing this modification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanRochCoulon JeanRochCoulon Awaiting requested review from JeanRochCoulon JeanRochCoulon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjdooks-ct @Gchauvon @JeanRochCoulon