Skip to content

Conversation

macumber
Copy link
Collaborator

Use noexcept versions of filesystem exists, is_directory, is_regular_file, remove, remove_all

Fixes #828

@macumber macumber requested a review from Copilot July 22, 2025 03:22
Copilot

This comment was marked as outdated.

@macumber macumber requested a review from Copilot July 22, 2025 03:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates filesystem operations to use noexcept versions that accept an error_code parameter instead of throwing exceptions. The change improves error handling by allowing the code to handle filesystem errors gracefully rather than through exception propagation.

  • Replaces throwing filesystem functions with noexcept versions that use boost::system::error_code
  • Updates filesystem operations including exists, is_directory, is_regular_file, remove, and remove_all
  • Maintains existing logic while improving error handling robustness

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
WorkflowController.cpp Updates measure directory existence check and removal to use error_code
BCLMeasureDialog.cpp Updates measure directory existence checks in folder creation logic
ScriptItem.cpp Updates database file existence and removal operations
ScheduleFileInspectorView.cpp Updates file existence check for schedule file validation
ResultsTabView.cpp Updates directory existence checks for results searching
OSItem.cpp Updates path existence check in item creation
OSDocument.cpp Updates weather file path validation and removal operations
LocationTabView.cpp Updates weather file removal with noexcept version
ApplyMeasureNowDialog.cpp Updates file existence check for reload path validation
OpenStudioApp.cpp Updates various filesystem checks including QtWebEngine path and DView validation
PathWatcher.cpp Updates file/directory existence checks in path watching functionality

@macumber macumber merged commit 357b26d into develop Jul 24, 2025
10 checks passed
@macumber macumber deleted the 828_noexcept_filesystem branch July 24, 2025 03:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filesystem exists throws an exception
1 participant