fix(fluent-editor): Fix click issues with rich text components in Edge browser #3655
Conversation
WalkthroughThe keyDownHandler in packages/renderless/src/fluent-editor/index.ts now conditionally handles click events to toggle fullscreen, in addition to existing Escape key handling. No function signatures or public APIs changed. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FullscreenButton
participant Editor
participant Handler as keyDownHandler
User->>FullscreenButton: Click
FullscreenButton->>Handler: Event(type="click")
Handler->>Editor: Toggle fullscreen
User->>Editor: Keydown (Escape)
Editor->>Handler: Event(key="Escape")
Handler->>Editor: Toggle fullscreen (if currently fullscreen)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/renderless/src/fluent-editor/index.ts (1)
140-146: Harden Escape detection (deprecated keyCode) and keep click handling — cross-browser fixGood call scoping the non-keyboard path to clicks. To make Escape handling reliable in Edge and modern browsers (where
keyCodeis deprecated and can be 0/undefined), detect Escape viaevent.keyfirst and fall back tokeyCode.Proposed change:
- if (e.keyCode) { - if (e.keyCode === 27 && state.isFullscreen) { - state.isFullscreen = !state.isFullscreen - } - } else if (e.type === 'click') { - state.isFullscreen = !state.isFullscreen - } + if (e.type === 'keydown') { + const isEscape = + (typeof (e as any).key === 'string' && (e as any).key === 'Escape') || + (e as any).keyCode === 27 + if (isEscape && state.isFullscreen) { + state.isFullscreen = !state.isFullscreen + } + } else if (e.type === 'click') { + state.isFullscreen = !state.isFullscreen + }Suggested quick validation:
- Chrome/Firefox/Edge: Enter fullscreen via the toolbar button (click), then press Escape to exit. Ensure no toggle occurs on other keys.
- Edge specifically: Verify Escape works even if
keyCodeis not set, thanks toevent.key === 'Escape'.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/renderless/src/fluent-editor/index.ts(1 hunks)
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit