Add basic branding #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
jamshale
approved these changes
Jul 22, 2025
esune
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
LGTM, just a couple of comments for future consideration.
While currently it's only a couple more environment variables, it might be worth switching to a configuration file if/when we decide to have more UI/behaviour customization in order to avoid proliferation of envvars. As of now, this is perfectly fine though.
Comment on lines
+21
to
+26
| "PYDENTITY_WALLET_APP_ICON", | ||
| "https://raw.githubusercontent.com/openwallet-foundation-labs/PyDentity-Wallet/refs/heads/main/assets/pydentity-icon.png", | ||
| ) | ||
| APP_LOGO = os.getenv( | ||
| "PYDENTITY_WALLET_APP_LOGO", | ||
| "https://raw.githubusercontent.com/openwallet-foundation-labs/PyDentity-Wallet/refs/heads/main/assets/pydentity-logo.png", |
There was a problem hiding this comment.
We could reference the assets served as static resources instead of an external resource, as default.
There was a problem hiding this comment.
I will look into this. perhaps a "branding" directory could be mounted which contains images and maybe css configurations in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to provide image URLs through env vars to enable basic app branding.