Skip to content

Conversation

Dindexx
Copy link
Contributor

@Dindexx Dindexx commented Jul 8, 2025

Short description of what this resolves:

Fixes parsing of auth requests that contain claim sets.

Changes proposed in this pull request:

Fixes: #

Signed-off-by: Kevin <kevin.dinh@lissi.id>
@Dindexx Dindexx requested a review from JoTiTu July 8, 2025 14:51
@Dindexx Dindexx self-assigned this Jul 8, 2025
Copy link
Contributor

@JoTiTu JoTiTu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem to fail

Signed-off-by: Kevin <kevin.dinh@lissi.id>
@Dindexx Dindexx merged commit 00748fd into main Jul 9, 2025
3 checks passed
Thomas-Roehlich-esatus pushed a commit to Thomas-Roehlich-esatus/wallet-framework-dotnet that referenced this pull request Jul 10, 2025
* fix claim sets parsing

Signed-off-by: Kevin <kevin.dinh@lissi.id>

* fix claim sets parsing 2

Signed-off-by: Kevin <kevin.dinh@lissi.id>

---------

Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>
JoTiTu added a commit that referenced this pull request Jul 22, 2025
* Fix the DCQL missing credential filtering (#349)

* use ValidMdoc in MDoc case

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

* filter missing creds by tracking creds that are only alternatives

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

* ensure filtering ONLY alternative credentials

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

---------

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* fix claim sets parsing (#351)

* fix claim sets parsing

Signed-off-by: Kevin <kevin.dinh@lissi.id>

* fix claim sets parsing 2

Signed-off-by: Kevin <kevin.dinh@lissi.id>

---------

Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* Adjusted engagementUri after ISO

Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

---------

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Co-authored-by: Johannes Tuerk <72355192+JoTiTu@users.noreply.github.com>
Co-authored-by: Kevin Dinh <92726228+Dindexx@users.noreply.github.com>
JoTiTu added a commit that referenced this pull request Aug 11, 2025
* Fix the DCQL missing credential filtering (#349)

* use ValidMdoc in MDoc case

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

* filter missing creds by tracking creds that are only alternatives

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

* ensure filtering ONLY alternative credentials

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

---------

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* fix claim sets parsing (#351)

* fix claim sets parsing

Signed-off-by: Kevin <kevin.dinh@lissi.id>

* fix claim sets parsing 2

Signed-off-by: Kevin <kevin.dinh@lissi.id>

---------

Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* Adjusted engagementUri after ISO

Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* Added FromUri for DeviceEngagement.cs

Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* Added SessionEstablishment

Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* Fixes to SessionEstablishment

Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* Made Handover nullable

Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

* Renaming in SessionEstablishment

Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>

---------

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Co-authored-by: Johannes Tuerk <72355192+JoTiTu@users.noreply.github.com>
Co-authored-by: Kevin Dinh <92726228+Dindexx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants