-
Notifications
You must be signed in to change notification settings - Fork 8
fix claim sets parsing #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin <kevin.dinh@lissi.id>
JoTiTu
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests seem to fail
Signed-off-by: Kevin <kevin.dinh@lissi.id>
Thomas-Roehlich-esatus
pushed a commit
to Thomas-Roehlich-esatus/wallet-framework-dotnet
that referenced
this pull request
Jul 10, 2025
* fix claim sets parsing Signed-off-by: Kevin <kevin.dinh@lissi.id> * fix claim sets parsing 2 Signed-off-by: Kevin <kevin.dinh@lissi.id> --------- Signed-off-by: Kevin <kevin.dinh@lissi.id> Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>
JoTiTu
added a commit
that referenced
this pull request
Jul 22, 2025
* Fix the DCQL missing credential filtering (#349) * use ValidMdoc in MDoc case Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> * filter missing creds by tracking creds that are only alternatives Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> * ensure filtering ONLY alternative credentials Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> --------- Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * fix claim sets parsing (#351) * fix claim sets parsing Signed-off-by: Kevin <kevin.dinh@lissi.id> * fix claim sets parsing 2 Signed-off-by: Kevin <kevin.dinh@lissi.id> --------- Signed-off-by: Kevin <kevin.dinh@lissi.id> Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * Adjusted engagementUri after ISO Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> --------- Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> Signed-off-by: Kevin <kevin.dinh@lissi.id> Co-authored-by: Johannes Tuerk <72355192+JoTiTu@users.noreply.github.com> Co-authored-by: Kevin Dinh <92726228+Dindexx@users.noreply.github.com>
JoTiTu
added a commit
that referenced
this pull request
Aug 11, 2025
* Fix the DCQL missing credential filtering (#349) * use ValidMdoc in MDoc case Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> * filter missing creds by tracking creds that are only alternatives Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> * ensure filtering ONLY alternative credentials Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> --------- Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * fix claim sets parsing (#351) * fix claim sets parsing Signed-off-by: Kevin <kevin.dinh@lissi.id> * fix claim sets parsing 2 Signed-off-by: Kevin <kevin.dinh@lissi.id> --------- Signed-off-by: Kevin <kevin.dinh@lissi.id> Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * Adjusted engagementUri after ISO Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * Added FromUri for DeviceEngagement.cs Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * Added SessionEstablishment Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * Fixes to SessionEstablishment Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * Made Handover nullable Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> * Renaming in SessionEstablishment Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> --------- Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id> Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com> Signed-off-by: Kevin <kevin.dinh@lissi.id> Co-authored-by: Johannes Tuerk <72355192+JoTiTu@users.noreply.github.com> Co-authored-by: Kevin Dinh <92726228+Dindexx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Fixes parsing of auth requests that contain claim sets.
Changes proposed in this pull request:
Fixes: #