Skip to content

Conversation

Thomas-Roehlich-esatus
Copy link
Contributor

Short description of what this resolves:

Two positions were found not to follow ISO/IEC 18013-5:2021 regarding mdoc during testing.

Changes proposed in this pull request:

  • Change FromCbor in BleUuid parsing a ByteString instead of String as writien in the standard. (See chapter 8.2.2.3)
  • Sheme for the engagement Uri is mdoc: not mdoc:// (See chapter 8.2.2.3)

Fixes: #352

JoTiTu and others added 3 commits July 10, 2025 17:34
…#349)

* use ValidMdoc in MDoc case

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

* filter missing creds by tracking creds that are only alternatives

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

* ensure filtering ONLY alternative credentials

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>

---------

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>
* fix claim sets parsing

Signed-off-by: Kevin <kevin.dinh@lissi.id>

* fix claim sets parsing 2

Signed-off-by: Kevin <kevin.dinh@lissi.id>

---------

Signed-off-by: Kevin <kevin.dinh@lissi.id>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>
Signed-off-by: Thomas Röhlich <t.roehlich@esatus.com>
@JoTiTu JoTiTu requested a review from Dindexx July 11, 2025 11:56
Copy link
Contributor

@Dindexx Dindexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR! It looks good to me :)

@Thomas-Roehlich-esatus
Copy link
Contributor Author

Glad to help, I actually have some more code. But here the workflow needs approval I thing?

@JoTiTu JoTiTu merged commit 77eaa63 into openwallet-foundation-labs:main Jul 22, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants