Skip to content

Conversation

JoTiTu
Copy link
Contributor

@JoTiTu JoTiTu commented Aug 5, 2025

Short description of what this resolves:

  • Add encrypted_response_enc_values_supported (authorization_encrypted_response_enc kept for backwards compatibility)
  • Add vp_formats_supported (vp_formats kept for backwards compatibility), update the properties for mso_mdoc and add vp_formats_not_supported error code
  • Refactor WalletMetadata

JoTiTu added 3 commits August 5, 2025 16:39
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
@JoTiTu JoTiTu requested a review from Dindexx August 5, 2025 14:57
JoTiTu added 2 commits August 6, 2025 10:27
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
JoTiTu added 3 commits August 8, 2025 16:55
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
@@ -96,6 +96,9 @@ public static Option<IEnumerable<T>> AsOption<T>(this IEnumerable<T> enumerable)
// ReSharper disable once PossibleMultipleEnumeration
: Some(enumerable);

public static Option<T> AsOption<T>(this T? value) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    var list = enumerable.ToList();
    return list.IsEmpty()
        ? Option<IEnumerable<T>>.None
        : list;


namespace WalletFramework.Oid4Vc.Tests.Oid4Vp.AuthRequest;

public class ClientMetadataTests
Copy link
Contributor

@Dindexx Dindexx Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are too opinionated and also too coupled to implementation details => I dont care if the function returns true or false, i care about if the program behaves correctly given the respective input (valid vp formats => can parse client metadata, invalid formats => cant parse clientmetadata).


namespace WalletFramework.Oid4Vc.Tests.Oid4Vp.AuthRequest;

public class ClientMetadataTests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing parsing test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already part of the AuthRequest parsing test. I think as long as we have not migrated the whole AuthRequest Parsing to proper Validation it doesn't add a lot of value, no?

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Copy link
Contributor

@Dindexx Dindexx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
@JoTiTu JoTiTu merged commit b5a9ec9 into main Aug 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants