-
Notifications
You must be signed in to change notification settings - Fork 8
Update Client- and Wallet Metadata #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
src/WalletFramework.Oid4Vc/Oid4Vp/AuthResponse/Encryption/EncryptedAuthorizationResponse.cs
Outdated
Show resolved
Hide resolved
src/WalletFramework.Oid4Vc/Oid4Vp/AuthResponse/Encryption/EncryptedAuthorizationResponse.cs
Outdated
Show resolved
Hide resolved
src/WalletFramework.Oid4Vc/Oid4Vp/Services/AuthorizationRequestService.cs
Outdated
Show resolved
Hide resolved
src/WalletFramework.Oid4Vc/Oid4Vp/Services/AuthorizationRequestService.cs
Outdated
Show resolved
Hide resolved
src/WalletFramework.Oid4Vc/Oid4Vp/Services/AuthorizationRequestService.cs
Outdated
Show resolved
Hide resolved
src/WalletFramework.Oid4Vc/Oid4Vp/Services/AuthorizationRequestService.cs
Outdated
Show resolved
Hide resolved
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
src/WalletFramework.Oid4Vc/Oid4Vp/Services/AuthorizationRequestService.cs
Outdated
Show resolved
Hide resolved
src/WalletFramework.Oid4Vc/Oid4Vp/Services/AuthorizationRequestService.cs
Outdated
Show resolved
Hide resolved
@@ -96,6 +96,9 @@ public static Option<IEnumerable<T>> AsOption<T>(this IEnumerable<T> enumerable) | |||
// ReSharper disable once PossibleMultipleEnumeration | |||
: Some(enumerable); | |||
|
|||
public static Option<T> AsOption<T>(this T? value) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var list = enumerable.ToList();
return list.IsEmpty()
? Option<IEnumerable<T>>.None
: list;
|
||
namespace WalletFramework.Oid4Vc.Tests.Oid4Vp.AuthRequest; | ||
|
||
public class ClientMetadataTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are too opinionated and also too coupled to implementation details => I dont care if the function returns true or false, i care about if the program behaves correctly given the respective input (valid vp formats => can parse client metadata, invalid formats => cant parse clientmetadata).
|
||
namespace WalletFramework.Oid4Vc.Tests.Oid4Vp.AuthRequest; | ||
|
||
public class ClientMetadataTests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing parsing test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already part of the AuthRequest parsing test. I think as long as we have not migrated the whole AuthRequest Parsing to proper Validation it doesn't add a lot of value, no?
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Short description of what this resolves: