Fix authentication priority: AWS-native -> docker login -> credHelpers -> credsStore #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s -> credsStore Signed-off-by: Rasmus Faber-Espensen <rfaber@gmail.com>
Signed-off-by: Rasmus Faber-Espensen <rfaber@gmail.com>
Signed-off-by: Rasmus Faber-Espensen <rfaber@gmail.com>
vsoch
reviewed
Jun 13, 2025
There was a problem hiding this comment.
Thanks @rasmusfaber. You will again need a bump to the version since this changes behavior of the library.
Signed-off-by: Rasmus Faber-Espensen <rfaber@gmail.com>
Yes, of course. Sorry for forgetting that. Done. |
vsoch
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple auth mechanisms are present in docker.json, the priority should be:
Currently credsStore is chosen above credHelpers, which is not correct.
Similarly, when using AWS ECR auth, the priority of the auths should be:
Currently credHelpers/credsStore will take priority.
Also, if a configured credHelper or credsStore fails, we now just warn and continue down the priority list.
Signed-off-by: Rasmus Faber-Espensen rfaber@gmail.com