-
Notifications
You must be signed in to change notification settings - Fork 141
doc: adjust to changes in Nemo #5194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5194 +/- ##
=======================================
Coverage 84.84% 84.85%
=======================================
Files 710 710
Lines 95517 95579 +62
=======================================
+ Hits 81045 81101 +56
- Misses 14472 14478 +6 🚀 New features to boost your workflow:
|
I'll review this once the Nemo PR is available here and we restarted CI to have a working preview. |
Something doesn't work here yet. On https://docs.oscar-system.org/previews/PR5194/Fields/intro/, the string of the 6th bullet point has changed, but the link doesn't go to where we want it to be. (The target it has is the one that is always chosen if we run into JuliaDocs/Documenter.jl#2668 or something similar). I'll investigate later. |
Can't reproduce locally. Thus restarting the jobs here to see if that was just some caching artifact or so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed fixed it.
Thanks |
Should be merged once Nemocas/Nemo.jl#2129 is released.