Skip to content

doc: adjust to changes in Nemo #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

doc: adjust to changes in Nemo #5194

merged 2 commits into from
Aug 18, 2025

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Aug 15, 2025

Should be merged once Nemocas/Nemo.jl#2129 is released.

@thofma thofma requested a review from lgoettgens August 15, 2025 06:01
@thofma thofma added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Aug 15, 2025
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.85%. Comparing base (7f7a868) to head (37b58d8).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5194   +/-   ##
=======================================
  Coverage   84.84%   84.85%           
=======================================
  Files         710      710           
  Lines       95517    95579   +62     
=======================================
+ Hits        81045    81101   +56     
- Misses      14472    14478    +6     

see 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens lgoettgens changed the title doc: adjust to changes in AbstractAlgebra doc: adjust to changes in Nemo Aug 15, 2025
@lgoettgens lgoettgens added documentation Improvements or additions to documentation needs nemo update labels Aug 15, 2025
@lgoettgens
Copy link
Member

I'll review this once the Nemo PR is available here and we restarted CI to have a working preview.

@lgoettgens
Copy link
Member

lgoettgens commented Aug 18, 2025

Something doesn't work here yet. On https://docs.oscar-system.org/previews/PR5194/Fields/intro/, the string of the 6th bullet point has changed, but the link doesn't go to where we want it to be. (The target it has is the one that is always chosen if we run into JuliaDocs/Documenter.jl#2668 or something similar).

I'll investigate later.

@lgoettgens lgoettgens closed this Aug 18, 2025
@lgoettgens lgoettgens reopened this Aug 18, 2025
@lgoettgens
Copy link
Member

Can't reproduce locally. Thus restarting the jobs here to see if that was just some caching artifact or so

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed fixed it.

@lgoettgens lgoettgens marked this pull request as ready for review August 18, 2025 12:00
@lgoettgens lgoettgens enabled auto-merge (squash) August 18, 2025 12:00
@thofma
Copy link
Collaborator Author

thofma commented Aug 18, 2025

Thanks

@lgoettgens lgoettgens merged commit c4d150c into master Aug 18, 2025
57 of 98 checks passed
@lgoettgens lgoettgens deleted the th/docupdate branch August 18, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation package: Nemo release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants