Updating SimulationOutputLogs tutorial #93
Merged
+340
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I have more to do so I was going to leaving it in preview for now. I was hoping the preview from the PR would update as I continued to push to the branch, but it seems to not be doing that. I'm a bit surprised, does it snapshot it when the pull-request is created? -- Andy
…_______________________________________________
Andrew Hamilton, Ph.D.
Engineering Division Chair
Monterey Bay Aquarium Research Institute
7700 Sandholdt Road, Moss Landing, CA 95039
Phone: 831-775-1861 Fax: 831-775-1646
http://www.mbari.org/
________________________________________
From: andermi ***@***.***>
Sent: Wednesday, August 6, 2025 6:18 PM
To: osrf/mbari_wec
Cc: Andrew Hamilton; Author
Subject: Re: [osrf/mbari_wec] Updating SimulationOutputLogs tutorial (PR #93)
@andermi approved this pull request.
LGTM 👍
—
Reply to this email directly, view it on GitHub<#93 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AO4ZFCOSNJY4OFOU5FN2IJL3MKSPZAVCNFSM6AAAAACDJJG7Y6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAOJUG43DQMRUG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@hamilton8415 It will update -- it just lags a bit. |
|
OK, I'll have faith. Driving home now and will check then... Thanks. -- ah
…_______________________________________________
Andrew Hamilton, Ph.D.
Engineering Division Chair
Monterey Bay Aquarium Research Institute
7700 Sandholdt Road, Moss Landing, CA 95039
Phone: 831-775-1861 Fax: 831-775-1646
http://www.mbari.org/
________________________________________
From: andermi ***@***.***>
Sent: Wednesday, August 6, 2025 6:23 PM
To: osrf/mbari_wec
Cc: Andrew Hamilton; Mention
Subject: Re: [osrf/mbari_wec] Updating SimulationOutputLogs tutorial (PR #93)
[https://avatars.githubusercontent.com/u/20071132?s=20&v=4]andermi left a comment (osrf/mbari_wec#93)<#93 (comment)>
I was hoping the preview from the PR would update as I continued to push to the branch
@hamilton8415<https://github.com/hamilton8415> It will update -- it just lags a bit.
—
Reply to this email directly, view it on GitHub<#93 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AO4ZFCME2I73XHMMHVZZI7D3MKTBXAVCNFSM6AAAAACDJJG7Y6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRSGEYTIOBRGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
…how csv in output file structure Signed-off-by: Michael Anderson <anderson@mbari.org>
Signed-off-by: Michael Anderson <anderson@mbari.org>
|
@hamilton8415 Is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a description of the .csv files that are generated by the simulator and the buoy.