Skip to content

Conversation

velvid
Copy link

@velvid velvid commented Jul 30, 2025

Since version 1.46.0, the language natively supports trailing_ones for all primitive integer types.

The manual implementations can be removed from the bit manipulation utilities.

@velvid velvid changed the title core(util): Remove trailing_ones. core (util): Remove trailing_ones. Jul 30, 2025
@velvid velvid changed the title core (util): Remove trailing_ones. core (util): Remove redundant trailing_ones. Jul 30, 2025
@velvid velvid marked this pull request as ready for review July 30, 2025 00:40
Copy link
Owner

@pdeljanov pdeljanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. We can remove these since they are now provided by Rust, but only in the dev-0.6 branch since this would be a semver-breaking change.

@velvid velvid changed the base branch from master to dev-0.6 August 19, 2025 21:37
@velvid velvid requested a review from pdeljanov August 19, 2025 21:37
@pdeljanov pdeljanov merged commit 31a9e6e into pdeljanov:dev-0.6 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants