allow to customize json search function #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstdio
requested changes
Aug 18, 2025
Comment on lines
33
to
42
| /** | ||
| * Postgresql {@code jsonb_path_exists} function to use | ||
| */ | ||
| public static String JSONB_PATH_EXISTS = "jsonb_path_exists"; | ||
|
|
||
| /** | ||
| * Postgresql {@code jsonb_path_exists_tz} function to use | ||
| */ | ||
| public static String JSONB_PATH_EXISTS_TZ = "jsonb_path_exists_tz"; | ||
|
|
There was a problem hiding this comment.
Hi. This code essentially introduces global mutable variables which is well known anti-pattern.
There was a problem hiding this comment.
well, whole jsonb support is based on static methods so i didnt seen any other way to make fields accessible. i used same "pattern" as for enabling date time support.
There was a problem hiding this comment.
I'm sure there are other ways to achieve this. Yeah, configuring date time support in this way was a quite a mistake I must say.
There was a problem hiding this comment.
i moved configuration to QuerySupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #187