-
Notifications
You must be signed in to change notification settings - Fork 531
PicoVector: Rewrite around new C pretty-poly.h. #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
249e3b9
to
fef9801
Compare
cb4573c
to
7cd9187
Compare
f9e45c4
to
34b3baa
Compare
11f8a18
to
2f978b0
Compare
82279a5
to
0364e31
Compare
Ignore sign compare and narrowing conversion errors in pretty-poly.h.
Pointers were being incremented as if they were bytes, rather than larger containers.
pretty-poly.h is not giving us fully clipped rectangles, so revert to the slower bounds checked pixel for now.
0364e31
to
feaf92e
Compare
* Remove Polygon types in favour of primitives .circle, .rectangle etc * Add a new Transform type for building up transformation matrices * Add support to set/clear transform on drawing
feaf92e
to
53a0e0b
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates the updated Pretty Poly library, which required a near complete rewrite of Pico Vector and will probably inform a redesign of the Python API.
There's now a proper C++ PicoVector library which will underpin the MicroPython bindings.
Alright Fonts are in an absolute state of turmoil, pending us figuring out how they might work. As the very least, the "af" format might change and break compatibility with the initial PicoVector release.
This is all a bit of a pain, but it will hopefully be worth it.
TODO