feat: add search controller + search and reverseSearch methods #311
Conversation
|
There was a problem hiding this comment.
Hi @TMSchipper 👋
Thank you for putting up the MR. These 'search' endpoints seem like a nice addition to the plugin.
I've left some comments on your code, please let me know if you have any questions or need clarification about my feedback. In addition to that there are also some linting issues that need to be solved. Primarily the @typescript-eslint rules are giving some trouble.
When you're done, please don't forget to add a Changeset to make sure your change gets scheduled for publication 🙂
| })); | ||
|
|
||
| // eslint-disable-next-line max-len | ||
| results = [...results, ...(Array.isArray(entriesWithContentType) ? entriesWithContentType : [])]; |
There was a problem hiding this comment.
Maby it is nicer if we do an early exit when there are no entries after fetching them. Then we don't have to check if entriesWithContentType is an array, we know it is.
| reverseSearch: async (ctx: Context & { params: { contentType: string; documentId: string } }) => { | ||
| const { contentType, documentId } = ctx.params; | ||
|
|
||
| // Zoek met filters via findMany omdat documentId geen primaire ID is |
There was a problem hiding this comment.
Please use English comments.
| const { contentType, documentId } = ctx.params; | ||
|
|
||
| // Zoek met filters via findMany omdat documentId geen primaire ID is | ||
| const [entry] = await strapi.entityService.findMany(contentType as UID, { |
There was a problem hiding this comment.
We could probably use the document service here with a findOne.
| const value = JSON.parse(coreStoreSettings[0].value); | ||
| const { mainField } = value.settings; | ||
|
|
||
| const entries = await strapi.entityService.findMany(uid, { |
There was a problem hiding this comment.
We could probably use the document service here.
| // Zoek met filters via findMany omdat documentId geen primaire ID is | ||
| const [entry] = await strapi.entityService.findMany(contentType as UID, { | ||
| filters: { documentId }, | ||
| fields: ['id', 'title', 'documentId'], |
There was a problem hiding this comment.
You can't assume the content type you're fetching here will always have a title field. You should use the same technique for finding the 'mainField' as it's done in the search controller.
| if (!coreStoreSettings[0]) return; | ||
|
|
||
| const value = JSON.parse(coreStoreSettings[0].value); | ||
| const { mainField } = value.settings; |
There was a problem hiding this comment.
Now that I'm thinking about it, it would be nice to make a dedicated service for finding the main field of content type. That should make it easy to reuse the code in both the endpoints.
No description provided.