Skip to content

run_qemu.sh: refactor loader.conf logic to disable and append #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 26, 2025

Instead of editing in place, comment out and append. This preserves "history", especially when building in incremental mode.

This is the "zero functional change" part of the QEMU / KVM / breakpoint PR #135 for issue #11

Instead of editing in place, comment out and append. This preserves
"history", especially when building in incremental mode.

This is the "zero functional change" part of the QEMU / KVM / breakpoint
PR pmem#135 for issue pmem#11

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb marked this pull request as ready for review April 26, 2025 03:35
@marc-hb marc-hb requested a review from stellarhopper as a code owner April 26, 2025 03:35
@marc-hb marc-hb merged commit 24b0a19 into pmem:main Apr 28, 2025
2 checks passed
@marc-hb marc-hb deleted the loader-append branch April 28, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants