Skip to content

Conversation

SivaAccionLabs
Copy link
Contributor

PNDA-4913

Tested
HDP RHEL

Copy link
Member

@trsmith2 trsmith2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a lot of unnecessary refactoring, when all that is necessary is a change to the flags passed to tar. Please simplify.

@SivaAccionLabs
Copy link
Contributor Author

Hi Trevor,
The reason for the refactoring is to gzip the Gobblin like in the rest of the pnda builds.
Extraction of Gobblin tar.gz gives the direct jars but in all other pnda components, tar.gz gives the directory with the component files.

Following is difference between gobblin and other pnda components.

[root@ip-172-31-31-186 sri]# tar -xvf gobblin-PNDA-develop.tar.gz
gobblin-PNDA-develop/gobblin-PNDA-develop.jar
gobblin-PNDA-develop/commons-jexl-2.1.1.jar
gobblin-PNDA-develop/kite-data-core-1.1.0.jar
gobblin-PNDA-develop/opencsv-3.8.jar

[root@ip-172-31-31-186 sri]# ls
commons-jexl-2.1.1.jar gobblin-PNDA-develop gobblin-PNDA-develop.jar gobblin-PNDA-develop.tar.gz kite-data-core-1.1.0.jar opencsv-3.8.jar

[root@ip-172-31-31-186 ss]# tar -xvf package-repository-develop.tar.gz
package-repository-develop/
package-repository-develop/tests/
package-repository-develop/async_dispatcher.py
package-repository-develop/asynchronize_tornado_handler.py
...
[root@ip-172-31-31-186 ss]# ls
package-repository-develop package-repository-develop.tar.gz

[root@ip-172-31-31-186 ss]# ls package-repository-develop
authorizer_local.py aws_repository.py fs_repository.py package_repository_rest_server.py
...

Thanks

@trsmith2 trsmith2 added the 5.2 label Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants