-
Notifications
You must be signed in to change notification settings - Fork 347
New command: m365 viva engage role list. Closes #6796 #6798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @MartinM85! We'll review it soon. |
I forgot to push the .spec file, but all checks passed anyway. |
That's weird, normally the workflow should fail when there is uncovered code. We'll have a look at it, thanks for letting us know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new CLI command m365 viva engage role list
to retrieve all available roles that can be assigned in Viva Engage. The implementation follows the project's established patterns for GraphCommand-based commands.
Key changes:
- Adds a new command to list Viva Engage roles using the Microsoft Graph API
- Implements comprehensive test coverage for the new functionality
- Provides complete documentation with usage examples and response formats
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/m365/viva/commands/engage/engage-role-list.ts |
Main command implementation using GraphCommand base class |
src/m365/viva/commands/engage/engage-role-list.spec.ts |
Complete test suite covering success and error scenarios |
src/m365/viva/commands/engage/EngageRole.ts |
TypeScript interface definition for EngageRole data structure |
src/m365/viva/commands.ts |
Command registration in the commands registry |
docs/src/config/sidebars.ts |
Documentation navigation structure update |
docs/docs/cmd/viva/engage/engage-role-list.mdx |
Comprehensive documentation with examples and response formats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, let's do some small tweaks before we merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from 2 small comments, it's good to go.
…nM85/cli-microsoft365 into feature/6796-viva-engage-role-list
Closes #6796