Enhancement: Ability to add sub groups using entra group member add. Closes #6480 #6822
Conversation
|
Thanks, we'll try to review it ASAP! |
|
Marking this PR with higher priority since it's blocking #6481, which has to be merged in the next major release. |
There was a problem hiding this comment.
Nice work @MartinM85, looks good and works great. Let's do a few changes before we merge it.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Entra Group member commands by adding support for sub-groups as members and improving the API with new parameter options. The main changes include deprecating the generic ids parameter in favor of more specific parameter names and implementing functionality to add sub-groups to groups using either IDs or display names.
- Adds new utility function
getGroupIdsByDisplayNamesfor batch group name resolution - Introduces
userIds,subgroupIds, andsubgroupNamesparameters to replace/supplement existing options - Deprecates the generic
idsparameter in favor of more descriptive alternatives
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/entraGroup.ts | Adds new utility function for batch group ID resolution by display names |
| src/utils/entraGroup.spec.ts | Comprehensive test coverage for the new group ID resolution functionality |
| src/m365/entra/commands/group/group-member-set.ts | Updates command to support new userIds parameter and deprecate ids |
| src/m365/entra/commands/group/group-member-set.spec.ts | Test coverage for new parameter validation and deprecation warnings |
| src/m365/entra/commands/group/group-member-add.ts | Major enhancement to support sub-group additions with new parameters |
| src/m365/entra/commands/group/group-member-add.spec.ts | Extensive test coverage for all new sub-group functionality |
| docs/docs/cmd/entra/group/group-member-set.mdx | Documentation updates for new parameters and deprecation notices |
| docs/docs/cmd/entra/group/group-member-add.mdx | Documentation for sub-group functionality and parameter changes |
Closes #6480