-
Notifications
You must be signed in to change notification settings - Fork 347
New command: spo file version keep. Closes #6774 #6826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks, we'll try to review it ASAP! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @Saurabh7019, I think we're almost ready to merge it with a few tiny changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, for new commands, we now also require a section called Permissions
for the docs page where we list the minimal permissions needed to run this command. Could you add it to this page as well, please?
More info: https://pnp.github.io/cli-microsoft365/contribute/new-command/writing-the-docs#permissions
Examples: any planner
command.
Thanks!
@Saurabh7019, are you using PowerShell? If I'm not mistaken, you should use |
@milanholemans, Thanks for checking. let's ignore this if it's not an issue for others. I just thought it might be a typo. I am using PowerShell, but it isn't working for me. ![]() |
I'm using PowerShell as well, and it seems to be working from my side: ![]() You can always create a new issue with the issue you are observing so we can find out what is causing this. |
Closes #6774