Skip to content

New command: spo file version keep. Closes #6774 #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Saurabh7019
Copy link
Contributor

Closes #6774

@Saurabh7019 Saurabh7019 marked this pull request as ready for review July 30, 2025 20:54
@milanholemans
Copy link
Contributor

Thanks, we'll try to review it ASAP!

@milanholemans milanholemans self-assigned this Aug 6, 2025
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Saurabh7019, I think we're almost ready to merge it with a few tiny changes.

@milanholemans milanholemans marked this pull request as draft August 7, 2025 15:26
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, for new commands, we now also require a section called Permissions for the docs page where we list the minimal permissions needed to run this command. Could you add it to this page as well, please?

More info: https://pnp.github.io/cli-microsoft365/contribute/new-command/writing-the-docs#permissions
Examples: any planner command.

Thanks!

@Saurabh7019 Saurabh7019 marked this pull request as ready for review August 9, 2025 10:39
@Saurabh7019
Copy link
Contributor Author

image

there's a minor issue in the above. the command has an extra -- . The correct usage is npm run devproxy:permissions -- -e "tenant=contoso"

Should we fix it as part of this issue?

@milanholemans
Copy link
Contributor

milanholemans commented Aug 9, 2025

@Saurabh7019, are you using PowerShell? If I'm not mistaken, you should use -- -- over there.
Edit: just tested it, seems to be working for me in PowerShell. Make sure that you select the right shell in the docs, for other shell it's a single -- indeed.

@Saurabh7019
Copy link
Contributor Author

@Saurabh7019, are you using PowerShell? If I'm not mistaken, you should use -- -- over there. Edit: just tested it, seems to be working for me in PowerShell. Make sure that you select the right shell in the docs, for other shell it's a single -- indeed.

@milanholemans, Thanks for checking. let's ignore this if it's not an issue for others. I just thought it might be a typo.

I am using PowerShell, but it isn't working for me.

image

@milanholemans
Copy link
Contributor

@Saurabh7019, are you using PowerShell? If I'm not mistaken, you should use -- -- over there. Edit: just tested it, seems to be working for me in PowerShell. Make sure that you select the right shell in the docs, for other shell it's a single -- indeed.

@milanholemans, Thanks for checking. let's ignore this if it's not an issue for others. I just thought it might be a typo.

I am using PowerShell, but it isn't working for me.
image

I'm using PowerShell as well, and it seems to be working from my side:

image

You can always create a new issue with the issue you are observing so we can find out what is causing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: spo file version keep
2 participants