-
-
Notifications
You must be signed in to change notification settings - Fork 13
Add Windows on arm64 as a supported platform #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @chalcolith, The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be:
Thanks. |
60d140d
to
e9a048e
Compare
@chalcolith https://github.com/ponylang/ponyup/blob/main/ponyup-init.ps1 should be updated to. |
Co-authored-by: Sean T Allen <sean@seantallen.com>
The windows corral for arm appears to hang often. |
I tried adding my local arm64 windows machine as a self-hosted runner. The crypto and net_ssl libs built much faster, so maybe the existing |
Massively increased the timeouts on the tests and they ran. @SeanTAllen I think the problem is that the arm build machines are underpowered -- they only have 1gb of memory. |
That seems odd given we are able to build LLVM without much issue on the arm machines. Perhaps we are accidentally running an amd64 binary that is being emulated. That would take quite a bit of time. We should verify each of the binaries is arm not amd64. Something isn't right here. The corral arm windows nightly takes 49 seconds to run. Is it building libressl that is taking all the time? That only took about 4 to 5 minutes in your PR to add to net_ssl - https://github.com/ponylang/net_ssl/actions/runs/15424265684/job/43407090596?pr=117. Update: Yeah all the time is going to "cloning net_ssl" which i think means buildings libressl which only takes 4 to 5 minutes when we did directly in the net_ssl repo:
that's an hour and 15 minutes. something definitely not right there. so our PR command in net_ssl is: |
@chalcolith I did a "test version" of crypto that doesn't build libressl as a post install step. So the only thing as part of that does build libressl is net_ssl. And looks like it was hanging on net_ssl being cloned which might be the building of libressl, but it takes way longer than we see for arm64 windows net_ssl where we only run the powershell command directly in pr.yml for Its 9 minutes in now. The x64 one was fully done in 5 minutes. I assume this is going to take the full 90 minutes we were seeing, once that is confirm, I will roll back the changes I did to test "only build single LibreSSL". |
@chalcolith and right after i wrote the above, it moved on to other portions of testing. this is going to be much quicker. i can only make the second half of sync on tuesday. perhaps we could chat then (3 pm eastern) or you could make office hours tomorrow as this is looking like it will take considerably more time than amd64 windows but much less than we have been seeing. i will update you on the final time to run if it turns out to be 90 or something ridiculous again despite looking promising. |
22 minutes total when not building libressl as part of the crypto package. |
23e5479
to
65fd734
Compare
65fd734
to
1c2e9ca
Compare
I think there are one or two things we should do to address the issues that I've indentified...
|
41f6f53
to
f0ff14b
Compare
f0ff14b
to
4fbd58f
Compare
@jemc can you give this a close review to see if there is anything you can see that is missing from this? i just did a review and found one bit that was missing in release.yml and added it. |
Allow building on arm64 Windows