Skip to content

Conversation

mnlc
Copy link

@mnlc mnlc commented Feb 16, 2020

Hi,

When the social links section breaks to two lines an icon stay on first row

image

Some mbox should fix the behavior

image

@OJFord
Copy link
Collaborator

OJFord commented Nov 22, 2021

Hi @mnlc, thanks, this LGTM (ideally I suppose we'd drop the trailing | on the first line, but it's an improvement for sure) - if you're still interested could you rebase to fix conflicts please, and then CI should run just so we can double check it looks right on the example.

@mnlc mnlc requested review from posquit0 and OJFord as code owners January 13, 2024 16:53
@github-actions github-actions bot added the size/S Small size issue or PR. label Jan 13, 2024
@mnlc
Copy link
Author

mnlc commented Jan 13, 2024

Hi @OJFord, I was thinking could be time to merge this lol. I haven't done the improvement, instead updated to wrap the added items in the meantime. I made a test uncommenting some socials, seems good. thanks

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Small size issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants