Fix \cvsubentry not compiling while description had any content. #524
+50
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, I simplified the `\cvsubentry` command to only take three arguments: the position you held, the dates you held it, and the description. Then I simplified its implementation and made it compile
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ent does what. Ensure that there is always a header-like title/position or organization displayed.
|
@posquit0 Can we get this reviewed and merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote its implementation and made it compile, and uncommented the code that exposed it in the examples, adding some dummy description data to expose the previously untested issues.
This solves #297 and #29 (which seemed to have been closed even though some still had issues with cv subentry)