Skip to content

New Adapter: Sparteo #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

New Adapter: Sparteo #3985

merged 2 commits into from
Aug 20, 2025

Conversation

t-sormonte
Copy link
Contributor

@t-sormonte t-sormonte commented Jun 4, 2025

🔧 Type of changes

  • [ X] new bid adapter

✨ What's the context?

We would like to allow our partners to be able to include us in s2s bidding.
The Go PR: prebid/prebid-server#4275

🧠 Rationale behind the change

The adapter logic is the same as the one we have implemented for the GO version

🔎 New Bid Adapter Checklist

  • [ X] verify email contact works
  • [X ] NO fully dynamic hostnames
  • [ X] geographic host parameters are NOT required
  • [ X] direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • [ X] if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • [ X] cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?
We have implemented the unit and integration test.
We have run several manual "real" tests.

🏎 Quality check

  • [ X] Are your changes following our code style guidelines?
  • [X ] Are there any breaking changes in your code?
  • [ X] Does your test coverage exceed 90%?
  • [ X] Are there any erroneous console logs, debuggers or leftover code in your changes?

@t-sormonte t-sormonte force-pushed the New-Adapter--Sparteo branch 2 times, most recently from bf1549b to 70b88dd Compare June 4, 2025 11:41
@t-sormonte t-sormonte marked this pull request as ready for review June 10, 2025 13:58
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure the Go and Java versions have feature parity before merging

@t-sormonte
Copy link
Contributor Author

t-sormonte commented Jun 25, 2025

Hi @AntoxaAntoxic ,
thank you for your time on this review, i have implemented your suggestions, please let me know if i have miss implemented some of your comments.

Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bidder itself looks good, some comments on the test class

@AntoxaAntoxic AntoxaAntoxic linked an issue Jun 30, 2025 that may be closed by this pull request
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. Only minor issues are left. Thank you!

@t-sormonte t-sormonte force-pushed the New-Adapter--Sparteo branch from 53c2d04 to 5f5206f Compare July 1, 2025 14:31
@t-sormonte
Copy link
Contributor Author

Hey @AntoxaAntoxic,
is there anything else from your review i may have missed ?
Thank you again for your time and review.

Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, but everything else looks good

the next step is the second approval and merging after all

@t-sormonte t-sormonte force-pushed the New-Adapter--Sparteo branch from 5f5206f to c2f1822 Compare July 8, 2025 09:09
AntoxaAntoxic
AntoxaAntoxic previously approved these changes Jul 8, 2025
@t-sormonte
Copy link
Contributor Author

Hi @CTMBNara, just a friendly follow-up on this PR.
Your feedback would be greatly appreciated whenever you have a moment.
Please let me know if you have any questions or if there's anything I can do to help with the review process.

@t-sormonte
Copy link
Contributor Author

Hi @CTMBNara,
Thank you for your time on this review,
i have implemented your suggestion, please let me know if you see anything else.

@t-sormonte t-sormonte force-pushed the New-Adapter--Sparteo branch from 6bbbff7 to 4c0ad2e Compare July 30, 2025 13:23
@osulzhenko osulzhenko requested a review from CTMBNara July 31, 2025 09:16
@t-sormonte t-sormonte force-pushed the New-Adapter--Sparteo branch from 4c0ad2e to c606fab Compare July 31, 2025 13:40
@t-sormonte
Copy link
Contributor Author

Hi @CTMBNara
I have implemented your last comment,
Let me know if you see anything else.
Thank you

@t-sormonte
Copy link
Contributor Author

Hi @CTMBNara and @AntoxaAntoxic ,
Thank you again for your time and reviews.
Have you got an idea on when this adapter will be included in a further release (even approximatively)?

@CTMBNara CTMBNara merged commit e5c5480 into prebid:master Aug 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: New Adapter: Sparteo
4 participants