Skip to content

Pubmatic: Support Alternate Bidder Codes #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025

Conversation

AntoxaAntoxic
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Aug 5, 2025
@AntoxaAntoxic AntoxaAntoxic added the do not merge Not the time for merging yet label Aug 5, 2025
@pm-isha-bharti
Copy link

Hi @AntoxaAntoxic,

If everything looks good, could we please proceed with merging this PR into the master? One of our publishers requires this update as a priority.

Thanks for your support.

@osulzhenko osulzhenko requested a review from CTMBNara August 12, 2025 12:54
@AntoxaAntoxic AntoxaAntoxic removed the do not merge Not the time for merging yet label Aug 19, 2025
@CTMBNara CTMBNara merged commit cd8f6c7 into master Aug 20, 2025
7 of 8 checks passed
@CTMBNara CTMBNara deleted the pubmatic-alternate-bidder-codes branch August 20, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: pubmatic: pass alternatebiddercodes to its adserver #2407
3 participants