Skip to content

add activity metric to prometheus-labels.yaml #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Aug 20, 2025

A new metric was added, but the prometheus labels were missing

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

A new metric was added ( activity ) without adding a prometheus match rule

🧠 Rationale behind the change

Prometheus labels work as expected

🧪 Test plan

We run it in production already

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code? - there are, but it's broken before, so meh.
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

A new metric was added, but the prometheus labels were missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant