Zeta Global SSP: Add sid parameter and audio support #3939

abermanov-zeta · 2024-09-25T13:56:29Z

prebid/prebid.github.io#5620

github-actions · 2024-09-25T13:57:16Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 01be5a3

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:34:	MakeRequests		78.6%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:65:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:82:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:87:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:121:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

przemkaczmarek · 2024-10-22T12:16:55Z

static/bidder-info/zeta_global_ssp.yaml

@@ -1,5 +1,8 @@
-endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA
+disabled: true
+endpoint: https://ssp.disqus.com/bid/prebid-server?sid={{.AccountID}}


endpoint is reachable;

@przemkaczmarek I'm sorry, I didn't get it (cannot upload your img). Yes, the endpoint is reachable. And sid query param is not mandatory in current implementation. What is the issue here?

@abermanov-zeta its not a issue, we just checking that endpoint is reachable. To merge PR 2ppl have to accept it. So if i check endpoint secound person dont have to.
When Ypu have cheanged endpoinyt we Have to check it one more time

@przemkaczmarek got it, thank you

bsardo · 2024-10-22T14:50:06Z

static/bidder-info/zeta_global_ssp.yaml

 userSync:
  redirect:
-    url: https://ssp.disqus.com/redirectuser?sid=GET_SID_FROM_ZETA&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}
+    url: https://ssp.disqus.com/redirectuser?sid={{.AccountID}}&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}


AccountID is not currently a supported macro for user sync URLs. We can add it. It should be noted that if it is not provided in the request to the cookie sync endpoint, the account ID will be set to "unknown".

@bsardo Yes, thank you. I've seen lists in macros.go. Having it in userSync is not critical for us, but would be great to have.

@bsardo the macro has been removed from the url

bsardo · 2024-11-04T17:04:35Z

Hi @abermanov-zeta, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

abermanov-zeta · 2024-11-21T15:17:13Z

Closing this MR due to #3849

…r sync endpoint.

github-actions · 2025-02-05T20:36:27Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 02f5a13

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

abermanov-zeta · 2025-02-05T20:49:09Z

Hi @abermanov-zeta, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:
import (
    "github.com/prebid/prebid-server/v3/adapters"
)
As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

@bsardo Done, thank you.

VeronikaSolovei9 · 2025-02-19T04:08:28Z

static/bidder-params/zeta_global_ssp.json

+    "sid": {
+      "type": "integer",
+      "description": "An ID which identifies the publisher"
+    }


Is this parameter required? Can it be 0?
If it is required, please add "required": ["sid"].
Example

@VeronikaSolovei9 No, it's not required. It can be 0.
Thank you.

VeronikaSolovei9 · 2025-02-19T04:09:32Z

adapters/zeta_global_ssp/zeta_global_ssp.go

@@ -3,7 +3,10 @@ package zeta_global_ssp
 import (
 	"encoding/json"
 	"fmt"
+	"github.com/prebid/prebid-server/v3/macros"


Please sort imports alphabetically.

@VeronikaSolovei9 done, thank you

VeronikaSolovei9 · 2025-02-19T04:17:31Z

static/bidder-info/zeta_global_ssp.yaml

@@ -1,5 +1,8 @@
-endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA
+disabled: true


Just to confirm: do you want to disable it intentionally?

@VeronikaSolovei9 by default, yes.

VeronikaSolovei9 · 2025-02-19T04:24:40Z

static/bidder-info/zeta_global_ssp.yaml

 userSync:
  redirect:
-    url: https://ssp.disqus.com/redirectuser?sid=GET_SID_FROM_ZETA&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}
+    url: https://ssp.disqus.com/redirectuser?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}


Verified. It works.

github-actions · 2025-02-19T20:20:06Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8fd20e3

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

bsardo · 2025-02-27T16:08:29Z

adapters/zeta_global_ssp/zeta_global_ssp.go

+		return nil, &errortypes.BadInput{
+			Message: "ext.bidder not provided",
+		}


Please add a supplemental JSON test that forces this error condition. Simply setting imp.ext to an empty string should suffice.

Added. Thank you

bsardo · 2025-02-27T16:08:38Z

adapters/zeta_global_ssp/zeta_global_ssp.go

+		return nil, &errortypes.BadInput{
+			Message: "ext.bidder not provided",
+		}


Please add a supplemental JSON test that forces this error condition. Simply setting imp.ext.bidder to an empty string should suffice.

Added. Thank you

bsardo · 2025-02-27T16:10:51Z

adapters/zeta_global_ssp/zeta_global_ssp.go

+		return nil, &errortypes.BadInput{
+			Message: "ext.bidder not provided",
+		}
+	}
+	var zetaSspImpExt openrtb_ext.ImpExtZetaGlobalSsp
+	if err := json.Unmarshal(bidderExt.Bidder, &zetaSspImpExt); err != nil {
+		return nil, &errortypes.BadInput{
+			Message: "ext.bidder not provided",
+		}


I know this may be copy/paste from another adapter but you might want to consider two different error messages so it is easier to discern exactly where a failure occurred.
As an example, some bidders use messages like
Error unmarshalling imp.ext
Error unmarshalling bidder ext

Right! Thank you. Fixed.

github-actions · 2025-03-04T14:08:40Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5dd01d4

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		85.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		94.4%

Zeta Global SSP Adapter: add 'sid' parameter, add audio support.

01be5a3

abermanov-zeta mentioned this pull request Sep 25, 2024

Zeta Global SSP: update supported modules, media types, PBS params. prebid/prebid.github.io#5620

Open

2 tasks

przemkaczmarek self-assigned this Oct 10, 2024

przemkaczmarek self-requested a review October 10, 2024 13:24

bsardo changed the title ~~Zeta Global SSP Adapter: add 'sid' parameter, add audio support.~~ Zeta Global SSP: Add sid parameter and audio support Oct 10, 2024

przemkaczmarek reviewed Oct 22, 2024

View reviewed changes

bsardo reviewed Oct 22, 2024

View reviewed changes

abermanov-zeta closed this Nov 21, 2024

abermanov-zeta added 2 commits February 5, 2025 21:21

Merge branch 'master' into zeta-global-ssp-refactor-param

9671736

Zeta SSP Adapter: use v3 packages, removed unsupported macro from use…

02f5a13

…r sync endpoint.

abermanov-zeta reopened this Feb 5, 2025

abermanov-zeta requested review from bsardo and przemkaczmarek February 10, 2025 12:56

bsardo self-assigned this Feb 10, 2025

bsardo assigned VeronikaSolovei9 and unassigned przemkaczmarek Feb 18, 2025

VeronikaSolovei9 reviewed Feb 19, 2025

View reviewed changes

Zeta SSP Adapter: sort imports alphabetically.

8fd20e3

abermanov-zeta requested a review from VeronikaSolovei9 February 21, 2025 15:04

bsardo reviewed Feb 27, 2025

View reviewed changes

Merge branch 'master' into zeta-global-ssp-refactor-param

db096a5

Zeta SSP Adapter: fix error messages and update tests.

5dd01d4

abermanov-zeta requested a review from bsardo March 4, 2025 14:09

VeronikaSolovei9 approved these changes Mar 6, 2025

View reviewed changes

bsardo approved these changes Mar 10, 2025

View reviewed changes

bsardo merged commit 50721c8 into prebid:master Mar 10, 2025
6 checks passed

cross-repo-issue-creation bot mentioned this pull request Mar 10, 2025

Port PR from PBS-Go: Zeta Global SSP: Add sid parameter and audio support prebid/prebid-server-java#3818

Open

abermanov-zeta mentioned this pull request Mar 12, 2025

Zeta Global SSP: update supported modules, media types, PBS params. prebid/prebid.github.io#5941

Merged

2 tasks

scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Mar 24, 2025

Zeta Global SSP: Add sid parameter and audio support (prebid#3939)

ad038b1

shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Jun 13, 2025

Zeta Global SSP: Add sid parameter and audio support (prebid#3939)

d6e9999

		@@ -1,5 +1,8 @@
		endpoint: https://ssp.disqus.com/bid/prebid-server?sid=GET_SID_FROM_ZETA
		disabled: true

Zeta Global SSP: Add sid parameter and audio support #3939

Zeta Global SSP: Add sid parameter and audio support #3939

Uh oh!

Conversation

abermanov-zeta commented Sep 25, 2024 • edited by bsardo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 25, 2024

Code coverage summary

zeta_global_ssp

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

przemkaczmarek Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bsardo commented Nov 4, 2024

Uh oh!

abermanov-zeta commented Nov 21, 2024

Uh oh!

github-actions bot commented Feb 5, 2025

Code coverage summary

zeta_global_ssp

Uh oh!

abermanov-zeta commented Feb 5, 2025

Uh oh!

VeronikaSolovei9 Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 19, 2025

Code coverage summary

zeta_global_ssp

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 4, 2025

Code coverage summary

zeta_global_ssp

Uh oh!

Uh oh!

Uh oh!

abermanov-zeta commented Sep 25, 2024 •

edited by bsardo

Loading

przemkaczmarek Nov 5, 2024 •

edited

Loading

VeronikaSolovei9 Feb 19, 2025 •

edited

Loading