Skip to content

Conversation

QuentinGallard
Copy link
Contributor

@QuentinGallard QuentinGallard commented Aug 1, 2025

🔧 Type of changes

  • bid adapter update

✨ What's the context?

SmileWanted adapter needs to support dynamic endpoint URLs based on the zoneId parameter to align with our server infrastructure requirements.

🧠 Rationale behind the change

The SmileWanted bidder endpoint needs to be constructed dynamically using the zoneId from the impression extension. This change:

  • Allows SmileWanted to identify which Prebid Server technology (Go or Java) is making the request, enabling us to provide optimized responses for each implementation
  • Enables more efficient filtering of ad calls by including the zoneId directly in the URL path, improving request routing and performance

🧪 Test plan

  • Updated unit tests to verify zoneId extraction and proper error handling
  • Updated integration tests to use the new endpoint pattern
  • Tests verify that missing or invalid zoneId returns appropriate error messages
  • Endpoint construction follows the pattern used by other adapters with dynamic parameters

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@QuentinGallard QuentinGallard force-pushed the quentin/sw_go_endpoint branch 2 times, most recently from cd6f915 to c1d8313 Compare August 1, 2025 08:13
Copy link

github-actions bot commented Aug 1, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c1d8313

smilewanted

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smilewanted/smilewanted.go:25:	MakeRequests		95.2%
github.com/prebid/prebid-server/v3/adapters/smilewanted/smilewanted.go:72:	MakeBids		94.4%
github.com/prebid/prebid-server/v3/adapters/smilewanted/smilewanted.go:115:	getMediaTypeForImp	85.7%
github.com/prebid/prebid-server/v3/adapters/smilewanted/smilewanted.go:129:	Builder			100.0%
total:										(statements)		93.8%

@bsardo bsardo changed the title SmileWanted endpoint now supports dynamic zoneId and integrates prebid server technology SmileWanted: Append zoneId to endpoint path Aug 6, 2025
@bsardo bsardo added the adapter label Aug 6, 2025
@QuentinGallard QuentinGallard force-pushed the quentin/sw_go_endpoint branch from c1d8313 to f885389 Compare August 18, 2025 13:28
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f885389

smilewanted

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smilewanted/smilewanted.go:25:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/smilewanted/smilewanted.go:72:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/smilewanted/smilewanted.go:115:	getMediaTypeForImp	100.0%
github.com/prebid/prebid-server/v3/adapters/smilewanted/smilewanted.go:129:	Builder			100.0%
total:										(statements)		100.0%

@QuentinGallard
Copy link
Contributor Author

Hi, the same pull request exists on Prebid Server Java project : prebid/prebid-server-java#4109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants