Skip to content

feat: unify the metrics across the repo(0) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 7, 2025
Merged

Conversation

guorong009
Copy link
Collaborator

@guorong009 guorong009 commented Jul 30, 2025

Description

Improve the report of benchmarks by using the unified metrics across the benchmarks

Changes

  • introduce SubMetrics (similar to Metrics for zkvm benchmarks) in utils
  • use SubMetrics for binius, plonky2, plonky3-sp1, plonky3-powdr benchmarks
  • git ignore the *.json files in root level

@guorong009 guorong009 changed the title feat: unify the metrics across the repo feat: unify the metrics across the repo(0) Aug 5, 2025
@guorong009 guorong009 requested a review from alxkzmn August 5, 2025 15:08
@guorong009 guorong009 marked this pull request as ready for review August 6, 2025 08:42
@guorong009 guorong009 requested a review from brech1 August 6, 2025 08:42
Copy link
Member

@alxkzmn alxkzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alxkzmn alxkzmn merged commit ccbeafb into CSP-Q3-2025 Aug 7, 2025
6 checks passed
@alxkzmn alxkzmn deleted the unify-metrics branch August 7, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants