Skip to content

feat: use criterion for benchmarks #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 11, 2025
Merged

feat: use criterion for benchmarks #25

merged 16 commits into from
Aug 11, 2025

Conversation

guorong009
Copy link
Collaborator

Description

Use the criterion for benchmarks

Changes

  • refactor the provekit benchmarks for use of criterion

@guorong009 guorong009 marked this pull request as ready for review August 7, 2025 09:16
@guorong009 guorong009 requested review from brech1 and alxkzmn August 7, 2025 09:16
alxkzmn
alxkzmn previously approved these changes Aug 7, 2025
Copy link
Member

@alxkzmn alxkzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brech1
Copy link
Member

brech1 commented Aug 7, 2025

@duguorong009 I submitted my updates, removed the binary file and implemented display for the SubMetrics. Everything should run correctly on cd provekit/ && cargo bench

@guorong009 guorong009 requested review from brech1 and alxkzmn August 8, 2025 05:14
alxkzmn
alxkzmn previously approved these changes Aug 8, 2025
@alxkzmn alxkzmn merged commit b8751b6 into CSP-Q3-2025 Aug 11, 2025
11 of 12 checks passed
@alxkzmn alxkzmn deleted the use-criterion branch August 11, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants