-
Notifications
You must be signed in to change notification settings - Fork 3
feat: measure the RAM footprint of benchmarks by using /usr/bin/time
util
#31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guorong009
wants to merge
21
commits into
CSP-Q3-2025
Choose a base branch
from
memory-measure-script
base: CSP-Q3-2025
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@guorong009 I see that you retained the RAM measurement in the old "measure" binaries, but I think it's ok to delete them and move the proof/preprocessing size measurement into the criterion benchmarks before the timings measurement. |
alxkzmn
approved these changes
Aug 20, 2025
brech1
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/usr/bin/time
util in measuring the RAM footprint of benchmarksChanges
measure_mem_avg.sh
scriptNUM_RUNS=4 ../measure_mem_avg.sh ...
; default value: 10)../measure_mem_avg.sh --json sha2_binius_mem_report.json -- [CMD]
)binius
,plonky2
,plonky3-powdr
,provekit
benchmarksSubMetrics
measurement to criterion bench codeprovekit
benchmarkNOTE
plonky3-sp1
since it could be replaced byere