-
Notifications
You must be signed in to change notification settings - Fork 35
Upstream PULPv2 features #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4c1c84
to
262c59d
Compare
14 tasks
732ec81
to
8d066cc
Compare
This was referenced Feb 27, 2025
Thank you for integrating iDMA into Chimera and preparing this PR. |
thommythomaso
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Multichannel PULP DMAC * [WIP] rename dmac_wrap * [WIP] PULP iDMA wrap: allow mux of rd ports, use axi structs * [WIP] add generated iDMA code to allow bender inclusion * [WIP] change inst64_snitch_pkg bender target to only `rtl` * [WIP] fix compilation errors in pulp_idma_wrap * [WIP] Fix compilation & optimization of PULP iDMA wrap, register FE * change tagged meta req assignment to always_comb bc of vopt issues * reg FE: fix ctrl response handshk and dim assignments * fix number of protocol bits and location * fix legalizer generation when burst and non-burst protocols combined * PULP iDMA wrap passes simple tests and is not unnecessarily slow * PULP DMA wrapper: INIT channel response is always valid * PULP DMA wrap: fix INIT read/write with spill registers * INIT read: only assign `buffer_in_valid_o` if datapath req valid * change HCI "master" to "initiator"... * remove assignment to no-longer-used HCI signals * add TCDM_MEM2BANKS parameter to pulp iDMA wrap * Prepare for PR * move pulp_idma_wrap to PULP Cluster repo * remove generated files * fix white spaces * Fix lint --------- Co-authored-by: Sergio Mazzola <smazzola@iis.ee.ethz.ch> Co-authored-by: Georg Rutishauser <georgr@iis.ee.ethz.ch> Co-authored-by: Michael Rogenmoser <michaero@iis.ee.ethz.ch>
8d066cc
to
92799c5
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Multichannel PULP DMAC * [WIP] rename dmac_wrap * [WIP] PULP iDMA wrap: allow mux of rd ports, use axi structs * [WIP] add generated iDMA code to allow bender inclusion * [WIP] change inst64_snitch_pkg bender target to only * [WIP] fix compilation errors in pulp_idma_wrap * [WIP] Fix compilation & optimization of PULP iDMA wrap, register FE * change tagged meta req assignment to always_comb bc of vopt issues * reg FE: fix ctrl response handshk and dim assignments * fix number of protocol bits and location * fix legalizer generation when burst and non-burst protocols combined * PULP iDMA wrap passes simple tests and is not unnecessarily slow * PULP DMA wrapper: INIT channel response is always valid * PULP DMA wrap: fix INIT read/write with spill registers * INIT read: only assign if datapath req valid * change HCI master to initiator... * remove assignment to no-longer-used HCI signals * add TCDM_MEM2BANKS parameter to pulp iDMA wrap * Prepare for PR * move pulp_idma_wrap to PULP Cluster repo * remove generated files * fix white spaces * Fix lint --------- Co-authored-by: Sergio Mazzola <smazzola@iis.ee.ethz.ch> Co-authored-by: Georg Rutishauser <georgr@iis.ee.ethz.ch> Co-authored-by: Michael Rogenmoser <michaero@iis.ee.ethz.ch> ----- Deployed from 92799c5
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Multichannel PULP DMAC * [WIP] rename dmac_wrap * [WIP] PULP iDMA wrap: allow mux of rd ports, use axi structs * [WIP] add generated iDMA code to allow bender inclusion * [WIP] change inst64_snitch_pkg bender target to only * [WIP] fix compilation errors in pulp_idma_wrap * [WIP] Fix compilation & optimization of PULP iDMA wrap, register FE * change tagged meta req assignment to always_comb bc of vopt issues * reg FE: fix ctrl response handshk and dim assignments * fix number of protocol bits and location * fix legalizer generation when burst and non-burst protocols combined * PULP iDMA wrap passes simple tests and is not unnecessarily slow * PULP DMA wrapper: INIT channel response is always valid * PULP DMA wrap: fix INIT read/write with spill registers * INIT read: only assign if datapath req valid * change HCI master to initiator... * remove assignment to no-longer-used HCI signals * add TCDM_MEM2BANKS parameter to pulp iDMA wrap * Prepare for PR * move pulp_idma_wrap to PULP Cluster repo * remove generated files * fix white spaces * Fix lint --------- Co-authored-by: Sergio Mazzola <smazzola@iis.ee.ethz.ch> Co-authored-by: Georg Rutishauser <georgr@iis.ee.ethz.ch> Co-authored-by: Michael Rogenmoser <michaero@iis.ee.ethz.ch> ----- Deployed from 92799c5
github-actions bot
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Multichannel PULP DMAC * [WIP] rename dmac_wrap * [WIP] PULP iDMA wrap: allow mux of rd ports, use axi structs * [WIP] add generated iDMA code to allow bender inclusion * [WIP] change inst64_snitch_pkg bender target to only * [WIP] fix compilation errors in pulp_idma_wrap * [WIP] Fix compilation & optimization of PULP iDMA wrap, register FE * change tagged meta req assignment to always_comb bc of vopt issues * reg FE: fix ctrl response handshk and dim assignments * fix number of protocol bits and location * fix legalizer generation when burst and non-burst protocols combined * PULP iDMA wrap passes simple tests and is not unnecessarily slow * PULP DMA wrapper: INIT channel response is always valid * PULP DMA wrap: fix INIT read/write with spill registers * INIT read: only assign if datapath req valid * change HCI master to initiator... * remove assignment to no-longer-used HCI signals * add TCDM_MEM2BANKS parameter to pulp iDMA wrap * Prepare for PR * move pulp_idma_wrap to PULP Cluster repo * remove generated files * fix white spaces * Fix lint --------- Co-authored-by: Sergio Mazzola <smazzola@iis.ee.ethz.ch> Co-authored-by: Georg Rutishauser <georgr@iis.ee.ethz.ch> Co-authored-by: Michael Rogenmoser <michaero@iis.ee.ethz.ch> ----- Deployed from 92799c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cleans up and puts together the commits of the following branches
that can now be deleted.
From the previous (never merged) PR #49:
The
pulp_idma_wrap
is also moved from here to the PULP Cluster repository, following the same approach of Astral.