Data Buffer Validation Issue #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thommythomaso
force-pushed
the
cl/rdmux
branch
from
3895ff1 to
4f3ba2e
Compare
--------- Co-authored-by: Chaoqun Liang <chaoqun.liang@unibo.it>
thommythomaso
force-pushed
the
cl/rdmux
branch
from
4f3ba2e to
d77382f
Compare
thommythomaso
approved these changes
Feb 27, 2025
thommythomaso
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r_dp_valid_i needs to be checked before shifting data to prevent unintended behavior.
Root Cause:
src_prot may retain its value from the previous data movement. When using AXI Stream as src_prot, whether it retains the previous value depends on the capacity of the stream FIFO (NumAxInFlight) and the number of entries used during the last data movement. As a result, src_prot can remain unchanged.
Then if data is shifted into the buffer without verifying r_dp_valid_i, it can cause an unintended state where the data buffer is no longer empty. This will trigger unintended behavior at the write end of the buffer.