Skip to content

Fixed a bug in finding possible parent sets in FCI #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2024
Merged

Fixed a bug in finding possible parent sets in FCI #192

merged 2 commits into from
Aug 24, 2024

Conversation

kenneth-lee-ch
Copy link
Contributor

I realized there's a bug in the function is_possible_parent that I created for the orientation rules in FCI.

kunwuz
kunwuz approved these changes Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@kunwuz kunwuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing it!

@kunwuz kunwuz merged commit ecc66e3 into py-why:main Aug 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunwuz kunwuz kunwuz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenneth-lee-ch @kunwuz