Skip to content

Use submodules instead of downloads #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 15, 2025
Merged

Use submodules instead of downloads #44

merged 9 commits into from
May 15, 2025

Conversation

kratman
Copy link
Contributor

@kratman kratman commented May 15, 2025

This should prevent having to download the zips and extract them. It will also streamline the build process

@kratman kratman self-assigned this May 15, 2025
@kratman kratman requested a review from a team as a code owner May 15, 2025 14:09
Copy link
Member

@MarcBerliner MarcBerliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one small change. I'm fine with keeping a larger python range for pybammsolvers (but apparently the macos wheels don't build)

@kratman kratman requested a review from MarcBerliner May 15, 2025 14:44
@kratman kratman merged commit 7b9eaff into main May 15, 2025
21 of 22 checks passed
@kratman kratman deleted the feat/submodules branch May 15, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants