Skip to content

Fix IDASolve error with time steps too close together #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix IDASolve error with time steps too close together #53

wants to merge 3 commits into from

Conversation

MarcBerliner
Copy link
Member

Fixes the error

tout1 too close to t0 to attempt initial condition calculation

which appears when points in t_eval are too close together. The value of tout1 provides the direction of integration and the order of magnitude of the step, meaning its true value is unimportant. This PR adds a buffer to tout1 to avoid the error.

This is the same issue as #35, just with IDASolve instead of IDACalcIC.

@MarcBerliner MarcBerliner requested a review from a team as a code owner August 8, 2025 19:21
agriyakhetarpal
agriyakhetarpal approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I'm too familiar with these code paths, but here's an approval to speed up a new release. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agriyakhetarpal agriyakhetarpal agriyakhetarpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcBerliner @agriyakhetarpal