Fix failing Windows wheel builds #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, the unit tests from the test suite are passing fully: https://github.com/pybamm-team/pybammsolvers/actions/runs/17162209565/job/48693989526?pr=55 I cancelled the job because it's going to add another 15 minutes to the workflow run (5-6 minutes per wheel build). I think we should be in a position to merge this now; I'll revert the commits added for testing. |
MarcBerliner
previously approved these changes
Aug 22, 2025
There was a problem hiding this comment.
Great work @agriyakhetarpal! Approving since the previous version ran successfully
Saransh-cpp
requested changes
Aug 22, 2025
Saransh-cpp
approved these changes
Aug 22, 2025
MarcBerliner
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SuiteSparse port was split into its substituent packages in the
vcpkgrepodata (see microsoft/vcpkg#41929). Sincevcpkgversions the ports of its libraries along with itself, the only way to makevcpkg's builds inmanifest-mode reproducible is to pin to a specific version of it. From the oldest successful wheel build for PyBaMM before thepybammsolversunvendoring, I've switched tovcpkgv2024.12.16 to fix the Windows wheels. The only difference in these Windows wheel builds after SuiteSparse and SUNDIALS were updated for Linux and macOS in #39 is that we use SUNDIALS v6.5.0 and an older port of SuiteSparse, which brings v5.8.0.This PR should help with the contemporary PRs to build for platforms/architectures. However, I think one of the ways to ease the infrastructure burden going forward would be to migrate to the Meson build system and meson-python build backend, which should be a concerted effort to go in its own PR.
Closes #51