Skip to content

Drop pybind11 submodule and use it as a build-time dependency #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Aug 23, 2025

While both pathways are fine, we may find it easier to use the pybind11 Python package instead of using it as a submodule.

This ports one of my older PRs; pybamm-team/PyBaMM#3560 – which was stalled due to other reasons when the IDAKLU solver was considered an optional requirement.

@agriyakhetarpal agriyakhetarpal requested a review from a team as a code owner August 23, 2025 11:37
@agriyakhetarpal agriyakhetarpal changed the title Drop pybind11 submodule and use it as a Drop pybind11 submodule and use it as a build-time dependency Aug 23, 2025
@agriyakhetarpal
Copy link
Member Author

The builds are passing, but somehow we're picking up a different Python version at build time rather than the one requested in the matrix (a job with 3.12 is still building wheels for 3.13, which means that the idaklu shared object is not found as a result). It's strange!

@agriyakhetarpal
Copy link
Member Author

Setting PYBIND11_FINDPYTHON to OFF so as to not let it change the Python interpreter midway results in passing builds, but builds with cibuildwheel fail. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant