-
-
Notifications
You must be signed in to change notification settings - Fork 7
Drop pybind11 submodule and use it as a build-time dependency #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The builds are passing, but somehow we're picking up a different Python version at build time rather than the one requested in the matrix (a job with 3.12 is still building wheels for 3.13, which means that the |
Setting |
While both pathways are fine, we may find it easier to use the
pybind11
Python package instead of using it as a submodule.This ports one of my older PRs; pybamm-team/PyBaMM#3560 – which was stalled due to other reasons when the IDAKLU solver was considered an optional requirement.