Skip to content

pre-commit autoupdate (except jupytext) #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Feb 26, 2024

Holding back jupytext because I was getting an error locally. We can do it in a 2nd pr.


📚 Documentation preview 📚: https://pymc-examples--641.org.readthedocs.build/en/641/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz
Copy link
Collaborator

What about using nbqa ruff my_notebook.ipynb for the next one ;) ?

@maresb
Copy link
Contributor Author

maresb commented Feb 26, 2024

What about using nbqa ruff my_notebook.ipynb for the next one ;) ?

Ha, is that a thing??? Sounds very intriguing.

I don't work much with .ipynb notebooks anymore. (Instead I favor VS Code .py-style notebooks in most of my projects.) I'm just going for a really low-effort fix here since I was fixing the pre-commit stuff and the plugins are out-of-date.

@juanitorduz
Copy link
Collaborator

juanitorduz commented Feb 26, 2024

Haha yes! It is a thing! I just wanted to point it out 😄. No need to adopt it though. It does work really well (I use it to format my notebooks for myself).

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OriolAbril
Copy link
Member

superseeded by #690

@OriolAbril OriolAbril closed this Aug 2, 2024
@maresb maresb deleted the update-pre-commit branch August 3, 2024 08:00
@maresb
Copy link
Contributor Author

maresb commented Aug 3, 2024

Great, thanks @OriolAbril!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants